-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update code to not need implicit any, add hasProperty util #9394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vega-lite with Cloudflare Pages
|
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 00:00
5b95030
to
da3dc55
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 00:06
9345646
to
2587eff
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 00:17
8d49f74
to
0ca90f1
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 02:20
b205c43
to
b316497
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 02:57
88445a8
to
9952d67
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 03:07
b0702f2
to
a625be6
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 03:28
15bf3ca
to
2d76e0b
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 03:40
3f53163
to
6250370
Compare
domoritz
force-pushed
the
dom/updates-7234909
branch
from
July 31, 2024 11:21
1dd5b52
to
b2c5130
Compare
domoritz
changed the title
chore: update deps
fix: update deps including typescript, fix a few issues along the way, and improve code robustness, remove need for suppressImplicitAnyIndexErrors
Jul 31, 2024
domoritz
changed the title
fix: update deps including typescript, fix a few issues along the way, and improve code robustness, remove need for suppressImplicitAnyIndexErrors
fix: update code to not need implicit any
Jul 31, 2024
domoritz
changed the title
fix: update code to not need implicit any
feat: update code to not need implicit any, add hasProperty util
Aug 1, 2024
lsh
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strongly in favor of these changes. This gives us a roadmap of where we can improve on types in the future.
# Conflicts: # yarn.lock
kanitw
reviewed
Oct 11, 2024
); | ||
expect(s).toBeDefined(); | ||
|
||
console.log(JSON.stringify(s)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasProperty
which checks whether the object has the property and it's not undefined