fix: mark position calculation when only x or y are defined #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
Nov 15, 2024
src/position.ts
Outdated
Comment on lines
99
to
104
| if ('x' in parentItem) { | ||
| left += parentItem.x; | ||
| } | ||
| if ('y' in parentItem) { | ||
| top += parentItem.y; | ||
| } |
There was a problem hiding this comment.
Maybe a simpler version could be something like left += parentItem.x ?? 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark Position Bug Fix
It's possible for only
xoryto be defined on a group item. The logic in place checked if both were defined and then summed their offsets. This fix checks them independently so that if only one or the other is defined, they are still summed up.Verification
Validated against
@adobe/react-spectrum-chartsthat this change fixes the bug I was seeing there.A test has been added to verify and catch this.