-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【テスト追加待ち】The Button Block has been made compatible for use within the Core Navigation Block. #1957
Draft
kurudrive
wants to merge
67
commits into
master
Choose a base branch
from
update/button-to-core-navigation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r use within the Core Navigation Block.
kurudrive
changed the title
【確認待ち】Update/button to core navigation
【確認待ち】The Button Block has been made compatible for use within the Core Navigation Block.
Apr 3, 2024
kurudrive
changed the title
【確認待ち】The Button Block has been made compatible for use within the Core Navigation Block.
【テスト追加待ち】The Button Block has been made compatible for use within the Core Navigation Block.
Apr 3, 2024
# Conflicts: # readme.txt
scssのビルド時warningを回避
…ailto-link リンクコンポーネントで tel: と mailto: リンクの不具合を修正
…ridcolcard__deprecated-1-87-0.html
…t work in tt4 and tt5.
開発系ビルド時にSource Mapを有効にしてGoogle Chromeでのデバッグをしやすく
【二人目確認中】[ Bug fix ][ Slider ] Fix an issue where full width alignment does not work in tt4 and tt5.
…r-display [ グリッドカラムカード ] カラムヘッダーメディアエリアやカラムフッターボタンエリアのデフォルトを「表示」に変更
…VK Components 1.6.1 )
[ VK Posts ] Add filter vk_post_taxonomies_html ( Update VK Components 1.6.1 )
# Conflicts: # .github/workflows/develop-test.yml # readme.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
WordPress 6.5 でコアのブロックに許可するインナーブロックをフックで改変できるようになったので...
どういう変更をしたか?
コアのナビゲーションブロック内にボタンブロックが使えるように指定
実装者の確認事項
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
変更内容について何を確認したか、どういう方法で確認をしたかなど
確認URL
ローカルでよろしくお願いいたします。
レビュワーに回す前の確認事項
レビュワー確認方法・確認内容など
レビュワー向け
レビュワーが確認して変更が反映されていない場合の確認事項
レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。