-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【2人目確認待ち】VK Compo を Composer から取得 #2363
Open
drill-lancer
wants to merge
10
commits into
develop
Choose a base branch
from
fix/vk-compo/composer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drill-lancer
requested review from
mthaichi,
kurudrive,
akito-38 and
MasayaMORIMOTO
December 5, 2024 06:37
MasayaMORIMOTO
changed the title
【確認待ち】VK Compo を Composer から取得
【確認中】VK Compo を Composer から取得
Dec 6, 2024
(1) npm run phpunit の正常動作を確認。 以上の確認を行いました。問題ないと思います。 |
MasayaMORIMOTO
changed the title
【確認中】VK Compo を Composer から取得
【2人目確認待ち】VK Compo を Composer から取得
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
vektor-inc/vektor-wp-libraries#145
どういう変更をしたか?
実装者の確認事項
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
変更内容について何を確認したか、どういう方法で確認をしたかなど
以上を確認しました。
レビュワーに回す前の確認事項
レビュワー確認方法・確認内容など
以上を確認お願いします。
レビュワー向け
レビュワーが確認して変更が反映されていない場合の確認事項
レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。