Generated code is invalid when only some return parameters are named

[viswajithiii]

Description

If I try to mock an interface with some returned values named (and others left as _), mockery generates invalid code, as it copies the _ names verbatim when generating the return function.

Mockery Version

2.16.0

Golang Version

1.19.1

Installation Method

• Binary Distribution
• Docker
• brew
• go install
• Other: [specify]

Steps to Reproduce

1. Have an interface like

//go:generate mockery -name=MyToyInterface --with-expecter
type MyToyInterface {
  MyMethod() (_ int, err error)
}

2. Run go generate

Expected Behavior

Valid generated code, like:

func (_c *MyToyInterface_MyMethod_Call) Return(_a0 int, err error) *MyToyInterface_MyMethod_Call {
	_c.Call.Return(_a0, err)
	return _c
}

Actual Behavior

You will see that the generated code is invalid, like:

func (_c *MyToyInterface_MyMethod_Call) Return(_ int, err error) *MyToyInterface_MyMethod_Call {
	_c.Call.Return(_, err)
	return _c
}

This is because it tries to use the _ as a value, which is a compile-time error: cannot use _ as value or type

[viswajithiii]

If you agree that this issue is valid, I'm happy to send a PR to fix. 😊

[viswajithiii]

Actually, this is 100% a bug, and the fix was tiny; went ahead and sent a PR here: #534.