Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSA SecureIDAuthenticaton change to SecurIDv2Authentication #239

Open
ymuwakki opened this issue Jun 2, 2022 · 1 comment · May be fixed by #241
Open

RSA SecureIDAuthenticaton change to SecurIDv2Authentication #239

ymuwakki opened this issue Jun 2, 2022 · 1 comment · May be fixed by #241
Labels
enhancement python Pull requests that update Python code waiting Waiting for answer

Comments

@ymuwakki
Copy link

ymuwakki commented Jun 2, 2022

The popular authMethod now for RSA Secure id is called : SecurIDv2Authentication

In file: github.com/venth/aws-adfs/blob/master/aws_adfs/authenticator.py line 184:
def _is_rsa_authentication(html_response):
auth_method = './/input[@id="authMethod"]'
and element.get('value') == 'SecurIDAuthentication'

Please change to the latest RSA SecureID Auth: SecurIDv2Authentication
or change: SecurIDAuthentication to SecurIDv2Authentication
@ymuwakki ymuwakki changed the title RSA RSA SecureIDAuthenticaton change to SecurIDv2Authentication Jun 2, 2022
@pdecat pdecat added enhancement python Pull requests that update Python code labels Jun 2, 2022
@pdecat pdecat self-assigned this Jun 3, 2022
@pdecat pdecat linked a pull request Jun 3, 2022 that will close this issue
Draft
@pdecat
Copy link
Collaborator

pdecat commented Jun 3, 2022

Hi @ymuwakki, I've opened #241 to resolve this.

As I do not have access to an RSA SecurID account, could you please test it?

To install it from git:

pipx install --force git+https://github.com/venth/aws-adfs@rsa_securid_v2

@pdecat pdecat added the waiting Waiting for answer label Jun 10, 2022
@pdecat pdecat removed their assignment Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement python Pull requests that update Python code waiting Waiting for answer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support RSA SecurIDv2Authentication venth/aws-adfs
2 participants
@pdecat @ymuwakki