Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't correctly run tests against master version of jsonapi-resources #41

Closed
valscion opened this issue Dec 23, 2016 · 4 comments
Closed

Comments

@valscion
Copy link
Member

We've got something wrong with the gem specifications and/or TravisCI setup, such that the tests against master version of jsonapi-resources aren't actually ran at all. This can be seen from e.g. this test run: https://travis-ci.org/venuu/jsonapi-authorization/jobs/186102969

If anyone wants to chime in and help with this, please do so :). This could be a good first PR to handle! If you have any questions, I'll try to answer to the best of my knowledge.

@nruth
Copy link
Contributor

nruth commented Jun 28, 2018

It looks like this has been fixed and can be closed? https://travis-ci.org/venuu/jsonapi-authorization runs through. Probably to do with moving from a beta JR version (that it couldn't find) to 0.9.

@valscion
Copy link
Member Author

Ah, unfortunely no. We'll likely need something along the lines I deleted in #57 in the .travis.yml:

 env:
   - JSONAPI_RESOURCES_VERSION=0.9 RAILS_VERSION=4.1.0
   - JSONAPI_RESOURCES_VERSION=0.9 RAILS_VERSION=4.2.0
+  - JSONAPI_RESOURCES_VERSION=master RAILS_VERSION=4.2.0
+  - JSONAPI_RESOURCES_VERSION=master RAILS_VERSION=4.1.0
 rvm:
 - 2.1.2
 before_install: gem install bundler -v 1.11.2
+matrix:
+  allow_failures:
+    - env: JSONAPI_RESOURCES_VERSION=master RAILS_VERSION=4.2.0
+    - env: JSONAPI_RESOURCES_VERSION=master RAILS_VERSION=4.1.0 

So currently we're not even trying to run the specs against master.

@nruth
Copy link
Contributor

nruth commented Jun 30, 2018

Sorry I completely misread this issue and thought it was saying the CI didn't run against the master of this project repo (i.e. couldn't test itself).

@valscion
Copy link
Member Author

We're currently running multiple tests against different rails and pundit versions since #104 and pull requests leading up to it.

In #98, we went with testing only JR 0.9 as we already test for different versions of Rails and Pundit. It would make the tests quite lengthy if we also wanted to test for different versions of JR, so I don't think it's worth the effort now.

It might be that we need to tweak CI config once JR 0.10 is released some point in the future (see #64) but for now, this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants