Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + W closes the terminal #1199

Closed
misgeatgit opened this issue Dec 14, 2016 · 17 comments
Closed

Ctrl + W closes the terminal #1199

misgeatgit opened this issue Dec 14, 2016 · 17 comments
Labels
help wanted Contributions wanted towards the issue 🤯 Type: Compatibility Issue contains information about a compatibility issue in Hyper

Comments

@misgeatgit
Copy link

When typing Ctrl + W inside vim, the terminal closes.

@annnoo
Copy link

annnoo commented Dec 14, 2016

At least it would be a good idea to be able to switch the shortcuts via config-file. I just edited the accelerators.js file manually (removed the 'W' at Close Session)

Edit:
Even if you edit the file, Ctrl+W is not working in Vim (On Windows).

@timothyis timothyis added 🤯 Type: Compatibility Issue contains information about a compatibility issue in Hyper help wanted Contributions wanted towards the issue labels Dec 14, 2016
@misgeatgit
Copy link
Author

Also

  • Opening the terminal and typing Ctrl + d closes the terminal.
  • Unable to delete the last line with Ctrl + k as in bash shell.

@annnoo
Copy link

annnoo commented Dec 15, 2016

Are you using Windows?

I have the strange feeling that no shortcut with the Ctrl key is working..

@misgeatgit
Copy link
Author

misgeatgit commented Dec 15, 2016

@annnoo I'm on Ubuntu 14.04.

@annnoo
Copy link

annnoo commented Dec 15, 2016

@misgeatgit Oh okay. I just thought that this is maybe a Windows only problem.

@parro-it
Copy link
Contributor

Opening the terminal and typing Ctrl + d closes the terminal.

This is a standard shortcut on all terminal emulators I'm aware of...

@jlobos
Copy link

jlobos commented Dec 15, 2016

In Arch + Hyper & nvim Ctrl+w close terminal 😓

@misgeatgit
Copy link
Author

@parro-it You are correct about Ctrl + d, my bad.

@annnoo
Copy link

annnoo commented Dec 15, 2016

Ctrl + W is closing the current session. If you have only one session/window open it will close the whole program, because there aren't any other sessions left.

I guess the two main problems are

  1. Making it possible to change the shortcuts via settings file
  2. Ctrl-key is not working in applications inside of Hyper

@nbolten
Copy link

nbolten commented Dec 16, 2016

Hi, I've put in a pull request that hopefully addresses this issue here: #1191 . It would make the default mod key into Ctrl+Shift on Windows and Linux so that there are no longer conflicts with CLI apps using Ctrl shortcuts.

It does not make the mod key configurable in hyper.js, but I think there's another patch in the works for that.

Feedback is helpful! The pull request is surely not perfect.

@ppot
Copy link
Contributor

ppot commented Feb 12, 2017

I would request you to add desired keybinding for linux in comments at ppot#11

{
 "window:devtools":"Cmd+Alt+I",
 "window:reload":"Cmd+R",
 "window:reloadFull":"Cmd+Shift+R",
 "window:preferences":"Cmd+,",
 "zoom:reset":"Cmd+0",
 "zoom:in":"Cmd+plus",
 "zoom:out":"Cmd+-",
 "window:new":"Cmd+N",
 "window:minimize": "Cmd+M",
 "window:full": "Cmd-Ctrl-F",
 "window:close":"Cmd+Shift+W",
 
 "tab:new":"Cmd+T",
 "tab:next":"Cmd+shift+]",
 "tab:prev":"Cmd+shift+[",
 "pane:next":"Cmd+]",
 "pane:prev":"Cmd+[",
 "pane:left":"Cmd+Alt+Left",
 "pane:right":"Cmd+Alt+Right",
 "pane:up":"Cmd+Alt+Up",
 "pane:down":"Cmd+Alt+Down",
 "pane:vertical":"Cmd+D",
 "pane:horizontal":"Cmd+Shift+D",
 "pane:close":"Cmd+W",
 
 "editor:undo":"Cmd+Z",
 "editor:redo":"Cmd+Shift+Z",
 "editor:cut":"Cmd+X",
 "editor:copy":"Cmd+C",
 "editor:paste":"Cmd+V",
 "editor:selectAll":"Cmd+A",
 "editor:clearBuffer":"Cmd+K",
 
 "plugins:update": "Cmd+Shift+U"
}

@ppot ppot mentioned this issue Feb 12, 2017
26 tasks
@hf
Copy link

hf commented Feb 18, 2017

Again, this happens on my Windows too.

@ppot ppot mentioned this issue Apr 30, 2017
@im-n1
Copy link

im-n1 commented Jun 2, 2017

Hi guys,

I'm just sayin this is pretty much crucial thing. If I could somehow (read quickfix) disable all hyper shortcuts, that would do the trick (for now).

+1

@Juicy45
Copy link

Juicy45 commented Jun 5, 2017

Ctrl W close the terminal also on fedora 25 in nano.

@jnardiello
Copy link

I agree, this is a real issue for any linux power user. Expected behaviour for ctrl + w is to cancel latest word, not to end the session.

@aditya-konarde
Copy link

+1 for this issue. Haven't looked into how the hyperterm application is built yet, but if its using electron, the terminal emulator is actually running in a BrowserWindow instance, which has ctrl+w as the default shortcut for close tab.

@ppot
Copy link
Contributor

ppot commented Aug 15, 2017

close in #1876

@ppot ppot closed this as completed Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 🤯 Type: Compatibility Issue contains information about a compatibility issue in Hyper
Projects
None yet
Development

No branches or pull requests