Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on re-enabling WebGL renderer #3849

Closed
Stanzilla opened this issue Oct 6, 2019 · 4 comments
Closed

Work on re-enabling WebGL renderer #3849

Stanzilla opened this issue Oct 6, 2019 · 4 comments
Labels
👩‍🔬 Status: In Progress Issue or PR is currently active and work is in progress 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper WebGL Renderer
Milestone
3.2.0

Comments

@Stanzilla
Copy link
Collaborator

During #3830 we disabled the WebGL renderer. This ticket is to track what is needed to do before we can re-enable it.
@Stanzilla Stanzilla added 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper 👩‍🔬 Status: In Progress Issue or PR is currently active and work is in progress labels Oct 6, 2019
@Stanzilla Stanzilla added this to the 3.1.0 milestone Oct 6, 2019
@GitSquared
Copy link
Contributor

The WebGL renderer was disabled with the xTerm 4 PR because enabling it causes this output:

Screenshot_20191007_104700

There are also some problems with text rendering. I'm unsure of what's causing this, and haven't tested it on Windows/macOS.

@Stanzilla Stanzilla modified the milestones: 3.1.0, 3.2.0 Oct 12, 2019
@Stanzilla Stanzilla pinned this issue Oct 12, 2019
@ivanwonder
Copy link
Contributor

Maybe we can pick this up with the new release of xterm.
https://github.com/microsoft/vscode/blob/35a8880109f28bbfc1dcc9f5305d32c195b60897/package.json#L56

@Stanzilla
Copy link
Collaborator Author

worth testing in any case

@timothyis timothyis unpinned this issue Feb 17, 2020
@LabhanshAgrawal
Copy link
Collaborator

Closing this as we have re-enabled the webgl renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👩‍🔬 Status: In Progress Issue or PR is currently active and work is in progress 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper WebGL Renderer
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@Stanzilla @ivanwonder @LabhanshAgrawal @GitSquared