Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation result difference on different operation systems #1057

Closed
IvanZosimov opened this issue Mar 23, 2023 · 1 comment
Closed

Compilation result difference on different operation systems #1057

IvanZosimov opened this issue Mar 23, 2023 · 1 comment

Comments

@IvanZosimov
Copy link

Description:
Hi 👋 , in https://github.com/actions/setup-java repo we faced an odd issue. The result output of the build command is different on Windows and macOS/Linux. Here you can check the output .js files:
Windows: windows.zip
Linux: linux.zip
Output of the git diff command can be found here: gitDiff.zip

Runners specification:

Tool Ubuntu 22.04.1 Windows 11
TS 4.2.3 4.2.3
Node.js 16.19.0 16.19.1
NPM 8.19.3 8.19.3
NCC 0.33.4 0.33.4

If you open the git diff output you may notice that the innards of these files are identical (same number of lines, same block of code), only structure is different - some blocks of code are shifted.

We don't have such a problem in other repos where we use ncc, like https://github.com/actions/setup-node files built on different OS are identical. Could you give us a hint, what we are doing wrong? Can we even expect that the built files should be identical ?

What have we tried by now:

  1. Updated ncc to the latest version -> saw no changes;

Related issues:
#831

@styfle
Copy link
Member

styfle commented Mar 23, 2023

Thanks, this sounds like a duplicate of #831 so I'll close this one.

There's an identical comment here #831 (comment)

I haven't looked into it but feel free to submit a PR if you have a fix 👍

@styfle styfle closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants