-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for TypeScript 5.0's array extends in tsconfig #1105
Conversation
smorimoto
commented
Aug 25, 2023
•
edited by styfle
Loading
edited by styfle
- add support for TypeScript 5.0's array extends in tsconfig
- drop support for Node.js 14
- remove tests for Tensorflow
- update most dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
![]() |
Secrets | ![]() ![]() ![]() ![]() |
View in Orca |
8723fe2
to
84e2616
Compare
84e2616
to
7195193
Compare
|
"the-answer": "^1.0.0", | ||
"tiny-json-http": "^7.0.2", | ||
"ts-loader": "^9.3.0", | ||
"tsconfig-paths": "^3.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you add a test to confirm the new behavior works as expected?
…llable Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
aa53d9e
to
78c35df
Compare
@styfle Done! |
To keep the amount of change to minimum, unrelated package updates were reverted. Let's do it with another PR as needed. |
@@ -0,0 +1,8 @@ | |||
{ | |||
"extends": ["./tsconfig.a.json", "./tsconfig.b.json"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Path to base configuration file to inherit from (requires TypeScript version 2.1 or later), or array of base files, with the rightmost files having the greater priority (requires TypeScript version 5.0 or later).
That is, the priorities are:
tsconfig.json
tsconfig.b.json
tsconfig.a.json
This test verifies that the override of the allowJs
property and the combination of A and B are working as expected.
@styfle Could you check this? |
Looks great, thanks! Running CI now |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
76b7810
to
a175fc1
Compare
@styfle The latest commits should also fix issues (not directly related to this PR!) related to native builds. I squashed the commit you added and put you in as a co-author. |
@styfle Additionally, branch protection appears to be enabled for the already-removed Node.js 14. Don't forget to update that as well! |
@styfle Could you kick the CI? |
Running CI again… |
Oh... Windows is always a nightmare... |
@styfle One last poke... |
c434d1b
to
3a5b299
Compare
@styfle I temporarily removed tfjs from the test as it was too unstable to break on other platforms when I fixed it for either platform. We can come back here again when it's correct in upstream. |
Signed-off-by: Sora Morimoto <sora@morimoto.io> Co-authored-by: Steven <steven@ceriously.com>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
…gyp` Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
3a5b299
to
d6557c7
Compare
d6557c7
to
637c285
Compare
- name: Use Node.js ${{ matrix.node }} | ||
uses: actions/setup-node@v3 | ||
with: | ||
cache: yarn | ||
node-version: ${{ matrix.node }} | ||
check-latest: true | ||
- name: Install Dependencies | ||
run: yarn install | ||
run: yarn global add node-gyp && yarn install --frozen-lockfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does node-gyp need to be a global?
This might be confusing for contributors since most people do not have node-gyp
installed globally.
Can we add it as a devDependency
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already listed there, but somehow it seems that Windows sometimes needs it in a global environment. I haven't investigated whether this is a problem with the package manager resolver or some kind of implementation, but generally there shouldn't be a major problem
Please update the PR description with example usage and link any existing issue, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 0.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@styfle Whoa! Thank you for taking care of the rest of the work! |