Frame-based errors for asset relocator parser

[igorklopov]

require('express');
await fn();

also

require('express');
{

also

require('express');
break;

[guybedford]

Are you sure this is running the latest ncc with the fix from #324 (ncc 0.17.0). I just tried this on the latest build and the errors seem to display correctly here.

[igorklopov]

@guybedford I confirm. Just checked again. This script reproduces it from scratch:

npm init -y
npm i @zeit/ncc@0.17.0
echo $"require('express');\nbreak;" > index.js
./node_modules/.bin/ncc build index.js

[igorklopov]

+ @zeit/ncc@0.17.0
added 1 package and audited 1 package in 1.25s
found 0 vulnerabilities

Error: Hash: 341323a9f53fee3ce68b
Version: webpack 5.0.0-alpha.9
Time: 90ms
Built at: 03/31/2019 8:37:41 PM
   Asset      Size  Chunks  Chunk Names
index.js  2.04 KiB   {404}  main
Entrypoint main = index.js
[950] ./index.js 721 bytes {404} [built] [failed] [1 error]

ERROR in ./index.js
Module build failed (from ./node_modules/@zeit/ncc/dist/ncc/loaders/relocate-loader.js):
SyntaxError: Unsyntactic break (2:0)
    at Object.re.raise (evalmachine.<anonymous>:1:179108)
    at Object.Q.parseBreakContinueStatement (evalmachine.<anonymous>:1:140053)
    at Object.Q.parseStatement (evalmachine.<anonymous>:1:138027)
    at Object.parseStatement (evalmachine.<anonymous>:1:30297)
    at Object.parseStatement (evalmachine.<anonymous>:1:575710)
    at Object.Q.parseTopLevel (evalmachine.<anonymous>:1:136703)
    at Object.parse (evalmachine.<anonymous>:1:133032)
    at Function.parse (evalmachine.<anonymous>:1:133799)
    at Object.e.exports (evalmachine.<anonymous>:1:466043)

    at compiler.close.n (evalmachine.<anonymous>:3:1349901)
    at _promise0.then._result0 (eval at create (evalmachine.<anonymous>:1:349386), <anonymous>:13:1)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)

[igorklopov]

However i expect

ERROR in ./index.js 2:0
Module parse failed: Unsyntactic break (2:0)
You may need an appropriate loader to handle this file type.
| require('express');
> break;
|

    at compiler.close.n (evalmachine.<anonymous>:3:1349901)
    at _promise0.then._result0 (eval at create (evalmachine.<anonymous>:1:349386), <anonymous>:13:1)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)

[igorklopov]

@guybedford btw it works well with 0.16.1. This one prints a correct message:

npm init -y
npm i @zeit/ncc@0.16.1
echo $"require('express');\nbreak;" > index.js
./node_modules/.bin/ncc build index.js

[guybedford]

Ahh I see. Yes the asset relocator does a parse, but does not provide syntax highlighted errors. Marking as an enhancement.

[igorklopov]

Thanks! Yeah, it is not unhandled rejection in 0.17.0, only wrong message.

[guybedford]

Implemented in vercel/webpack-asset-relocator-loader#63.