-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Regexp externals #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, sorry for the delayed review on this @huozhi.
The implementation seems sensbile. See the comment re the matching form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased, and changed the ordering in the object form.
Thanks again @huozhi for your work here.
Thank you for the great advice and quick improvements! @guybedford |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolves #647
Changes
Support regex pattern for externals, to exclude more external libs easily.
Regexp is supported natively, this can avoid adding extra libraries to support wildcard patterns like
pattern*
.Usage