TS interop test and fix #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Mar 21, 2021
| @@ -299,6 +299,8 @@ function ncc ( | |||
| transpileOnly, | |||
| compiler: eval('__dirname + "/typescript.js"'), | |||
| compilerOptions: { | |||
| allowSyntheticDefaultImports: true, | |||
There was a problem hiding this comment.
Do we also want to use esModuleInterop: true?
There was a problem hiding this comment.
I'm pretty sure that only affects output (to CJS, which this is now not), not interpretation.
styfle
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the TypeScript interop including a fix as well for enabling the synthetic default imports option and outputting ESM for Webpack to apply its own interop patterns instead of relying on the more complex TypeScript interop output. This will also reduce the size of TypeScript applications with ncc.