-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when using @azure/ms-rest-nodeauth #820
Comments
That is strange. When you remove the minify command, you can see the error is coming from The workaround is adding a |
It is interesting, but how it can works with @zeit/ncc then ? The dependencies are the same and the package.json too. |
It seems like its resolving the wrong package.json here It doesn't fail when using JS source, only TS source so that makes me think the cc @guybedford |
If it's just the |
@guybedford In this case, its not just the private fields, its actually the wrong package.json (it uses the root package.json from the cwd instead of node_modules/axios/package.json) |
We updated one of our projects from @zeit/ncc to @vercel/ncc and get a runtime error "TypeError: Cannot read property 'split' of undefined" since then. I could nail it down to a function import from @azure/ms-rest-nodeauth.
The attached file contains a minimal project demonstrating the error. To reproduce it, please execute these commands:
When going back to @zeit/ncc, the error doesn't occur anymore:
ncc-test.tar.gz
The text was updated successfully, but these errors were encountered: