From 3556cc4035ff327fff419f47b46db5594c98a811 Mon Sep 17 00:00:00 2001 From: Adam Lane Date: Wed, 14 Nov 2018 14:23:18 -0800 Subject: [PATCH] fix css cache-control max-age 0 bug (#335) Part of the fix for https://github.com/zeit/next.js/issues/5464 The other part is a next.js change I am checking in now. Fixes zeit/next.js#5464 Fixes #243 --- packages/next-css/css-loader-config.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/next-css/css-loader-config.js b/packages/next-css/css-loader-config.js index 5ed9b99e..19815a13 100644 --- a/packages/next-css/css-loader-config.js +++ b/packages/next-css/css-loader-config.js @@ -36,11 +36,11 @@ module.exports = ( // Options similar to the same options in webpackOptions.output // both options are optional filename: dev - ? 'static/css/[name].css' - : 'static/css/[name].[contenthash:8].css', + ? 'static/chunks/[name].css' + : 'static/chunks/[name].[contenthash:8].css', chunkFilename: dev - ? 'static/css/[name].chunk.css' - : 'static/css/[name].[contenthash:8].chunk.css', + ? 'static/chunks/[name].chunk.css' + : 'static/chunks/[name].[contenthash:8].chunk.css', orderWarning: false, reloadAll: true }) @@ -52,7 +52,8 @@ module.exports = ( if (!Array.isArray(config.optimization.minimizer)) { config.optimization.minimizer = [] } - config.optimization.minimizer.push(new require('optimize-css-assets-webpack-plugin')({})) + const OptimizeCssAssetsWebpackPlugin = require('optimize-css-assets-webpack-plugin'); + config.optimization.minimizer.push(new OptimizeCssAssetsWebpackPlugin({})) } const postcssConfig = findUp.sync('postcss.config.js', {