Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for _layout.js file #104

Closed
luisrudge opened this issue Oct 27, 2016 · 3 comments
Closed

support for _layout.js file #104

luisrudge opened this issue Oct 27, 2016 · 3 comments

Comments

@luisrudge
Copy link

Exactly like you support the _error.js file.
This would solve a common question people are asking (#71, https://twitter.com/luisrudge/status/790946965123112960).

The idea is look for a _layout.js file. If it exists, render it passing the current route's content as children.

@dlindenkreuz
Copy link
Contributor

Is this a duplicate of #88?

@luisrudge
Copy link
Author

It wasn't until you renamed the issue 😝

@dlindenkreuz
Copy link
Contributor

Hehe, kinda. The issue was originally about allowing animated route transitions which would need an editable top-level app component.

I guessed the root of the issue is not route transitions but rather having an editable top-level app component which would also solve many other issues like the current force re-mounting of all components (see #50). To better describe its core, I decided to rename the issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants