Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce webpack watcher aggregate timing #22418

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 22, 2021

Reduces the time the watcher waits for events coming in before compiling.

Reduces the time the watcher waits for events coming in before compiling.
@ijjk
Copy link
Member

ijjk commented Feb 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
buildDuration 11.8s 11.7s -103ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +89 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
/ failed reqs 0 0
/ total time (seconds) 2.304 2.251 -0.05
/ avg req/sec 1085.25 1110.84 +25.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.55 1.581 ⚠️ +0.03
/error-in-render avg req/sec 1612.41 1580.82 ⚠️ -31.59
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
amp-e3e9bc99..932c.js gzip 536 B 536 B
hooks-5023ef..3670.js gzip 888 B 888 B
index-3a2b03..c677.js gzip 227 B 227 B
link-177412b..043e.js gzip 1.67 kB 1.67 kB
routerDirect..1a66.js gzip 303 B 303 B
withRouter-9..1b7d.js gzip 302 B 302 B
Overall change 8.66 kB 8.66 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_buildManifest.js gzip 347 B 347 B
Overall change 347 B 347 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
index.html gzip 615 B 615 B
link.html gzip 621 B 621 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
buildDuration 13.6s 13.6s -5ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +89 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
677f882d2ed8..854c.js gzip 13.2 kB 13.2 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.65 kB 6.65 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
amp-e3e9bc99..932c.js gzip 536 B 536 B
hooks-5023ef..3670.js gzip 888 B 888 B
index-3a2b03..c677.js gzip 227 B 227 B
link-177412b..043e.js gzip 1.67 kB 1.67 kB
routerDirect..1a66.js gzip 303 B 303 B
withRouter-9..1b7d.js gzip 302 B 302 B
Overall change 8.66 kB 8.66 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_buildManifest.js gzip 347 B 347 B
Overall change 347 B 347 B
Serverless bundles
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_error.js 1.01 MB 1.01 MB
404.html 2.67 kB 2.67 kB
amp.amp.html 10.4 kB 10.4 kB
amp.html 1.86 kB 1.86 kB
hooks.html 1.92 kB 1.92 kB
index.js 1.01 MB 1.01 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.2 MB 5.2 MB

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
buildDuration 14.1s 13.9s -164ms
nodeModulesSize 42.6 MB 42.6 MB ⚠️ +89 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
/ failed reqs 0 0
/ total time (seconds) 2.27 2.17 -0.1
/ avg req/sec 1101.32 1152.21 +50.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.621 1.52 -0.1
/error-in-render avg req/sec 1541.93 1644.81 +102.88
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
597-dc8125e2..ef24.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 60 kB 60 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB
amp-33a09cb0..6745.js gzip 536 B 536 B
hooks-4e968a..f870.js gzip 902 B 902 B
index-5c6845..f75c.js gzip 230 B 230 B
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB
routerDirect..bb56.js gzip 306 B 306 B
withRouter-7..2133.js gzip 302 B 302 B
Overall change 8.57 kB 8.57 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
_buildManifest.js gzip 326 B 326 B
Overall change 326 B 326 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/reduce-watch-time-wait Change
index.html gzip 586 B 586 B
link.html gzip 593 B 593 B
withRouter.html gzip 582 B 582 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "UJaFXKtA9uwe83ga-qwkn",
+        "buildId": "k0xygTKLzaruTos6MkAoP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UJaFXKtA9uwe83ga-qwkn/_buildManifest.js"
+      src="/_next/static/k0xygTKLzaruTos6MkAoP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UJaFXKtA9uwe83ga-qwkn/_ssgManifest.js"
+      src="/_next/static/k0xygTKLzaruTos6MkAoP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "UJaFXKtA9uwe83ga-qwkn",
+        "buildId": "k0xygTKLzaruTos6MkAoP",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UJaFXKtA9uwe83ga-qwkn/_buildManifest.js"
+      src="/_next/static/k0xygTKLzaruTos6MkAoP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UJaFXKtA9uwe83ga-qwkn/_ssgManifest.js"
+      src="/_next/static/k0xygTKLzaruTos6MkAoP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "UJaFXKtA9uwe83ga-qwkn",
+        "buildId": "k0xygTKLzaruTos6MkAoP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UJaFXKtA9uwe83ga-qwkn/_buildManifest.js"
+      src="/_next/static/k0xygTKLzaruTos6MkAoP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UJaFXKtA9uwe83ga-qwkn/_ssgManifest.js"
+      src="/_next/static/k0xygTKLzaruTos6MkAoP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ab63888

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants