Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font optimization - Typekit font loaded twice #24872

Closed
janicklas-ralph opened this issue May 6, 2021 · 1 comment · Fixed by #25346
Closed

Font optimization - Typekit font loaded twice #24872

janicklas-ralph opened this issue May 6, 2021 · 1 comment · Fixed by #25346
Assignees
Milestone

Comments

@janicklas-ralph
Copy link
Contributor

What version of Next.js are you using?

10.2

What version of Node.js are you using?

14.16.1

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying your application?

next start

Describe the Bug

Support for Typekit font were added in this PR - #24834

The font file for typekit is loaded twice as seen in the font-manifest.json

Expected Behavior

Font file has to be added once in the font-manifest.json

To Reproduce

Run the with typekit integration test and look at the font-manifest.json for the typekit font

@janicklas-ralph janicklas-ralph added the bug Issue was opened via the bug report template. label May 6, 2021
@janicklas-ralph janicklas-ralph self-assigned this May 6, 2021
@timneutkens timneutkens added kind: bug and removed bug Issue was opened via the bug report template. labels May 7, 2021
@timneutkens timneutkens added this to the Iteration 20 milestone May 7, 2021
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants