-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to import react-dom/server in a server component #43810
Comments
It's similar to what https://github.com/FormidableLabs/react-ssr-prepass and others like https://github.com/kmoskwiak/useSSE rely on (e.g. a real or simulated pre-render pass to hoist certain work and then actually send it already digested into SSR as initial props) In general, this kind of pattern should become even more of an edge-case, as with RSC you could fetch/do async stuff anywhere and Next.js would attempt to deduplicate the requests. However, if you do need to render something static (as your example shows, but not pre-rendering your own app itself), you might be able to work around it by dynamically importing // app/precompile.js
const getData = async (component) => {
const ReactDOMServer = (await import('react-dom/server')).default;
const staticMarkup = ReactDOMServer.renderToStaticMarkup(component);
return staticMarkup;
};
export default getData;
// app/page.js
const STATIC_COMPONENT = <p>Static Component</p>;
export default async function TestPage() {
// this works OK
const prerenderStaticComponent = await getData(STATIC_COMPONENT);
// this does not work (error)
/**
* Error: Objects are not valid as a React child (found: object with keys {$$typeof, filepath, name, async}). * If you meant to render a collection of children, use an array instead.
*/
// const prerenderAClientComponent = await getData(PageWrapperClient);
// this does not work (warning)
/**
* Warning: Functions are not valid as a React child. This may happen if you return a Component instead of <Component /> from render. Or maybe you meant to call this function rather than return it.
*/
// const prerenderAServerComponent = await getData(PageWrapperServer);
return (
<PageWrapperClient>
<h3>This is a page with static markup</h3>
<div dangerouslySetInnerHTML={{ __html: prerenderStaticComponent }} />
</PageWrapperClient>
);
} But trying to render your actual tree of components will likely fail as they'll be client or server components and both cases will error out (not quite sure how Next.js internally is handling this to be able to render these new trees, if there's any webpack work involved and why it doesn't just work on its own) |
Same problem here. My use case is rendering a page with various components into a static RSS feed using |
I found this while trying to render a react component svg in a export async function GET(req: NextRequest): Promise<NextResponse> {
const ReactDOMServer = (await import('react-dom/server')).default
const component = <ReactComponent />
const svg = Buffer.from(ReactDOMServer.renderToString(component))
const png = await sharp(svg).flatten({ background: 'white' }).png().toBuffer()
return new NextResponse(png, {
status: 200,
headers: { 'Content-Type': 'image/png' },
})
} Importing ReactDOMServer dynamically does fix this. So thank you – just wanted to share my usecase :-) |
Thanks, dynamic import worked for me! My use case is to convert mdx to text to prepare my content for meilisearch, I think that use case is legitimate. Had to do something like this: export async function toMeilisearch(markdown: string | undefined) {
const { renderToString } = await import('react-dom/server')
// from @mdx-js/mdx
const content = await _evaluate(markdown ?? '', {
...runtime,
Fragment,
remarkPlugins: [remarkGfm, remarkFrontmatter],
development: false,
})
const rendered = renderToString(createElement(content.default))
// from html-to-text
return convert(rendered, {
selectors: [
{
selector: 'a',
options: {
ignoreHref: true,
uppercaseHeaderCells: false,
},
},
],
})
} |
I was able to import
and use it on the server |
Same problem building a sitemap.xml with dynamic urls imported from a database is my use case. |
I have the same problem |
Here's my solution to render jsx to string on both client and server on NextJS > 13 without having server component issue in import // render-client.js
// render-server.ts
// index.tsx
|
wow "use client";
// @ts-ignore
import ReactDom from "next/dist/compiled/react-dom/cjs/react-dom-server-legacy.browser.production";
import { SiRootme } from "react-icons/si";
export default function TestPage({}) {
const html = ReactDom.renderToStaticMarkup(<SiRootme />);
const json = JSON.stringify(["SiRootme", html]);
console.log({ icon: json });
return <></>;
} |
It does not work now: fails with the following message: |
This solution from @abiriadev worked for me. |
This should be the best answer as of today.
|
when I try to render a dynamic components with props it gives me this Error:
My code is like below and it runs when we call an api (so in the server side):
does anyone has a solution? |
It works indeed, but crashes with
If using That might feel obvious, but my need was to generate React code from an API endpoint which would return HTML, and have some React "client" run on the frontend, but I couldn't achieve that. |
Same Problem here. Has anyone found a solution to this issue? |
I don't think I hacked my way around this by creating my own wrapper around
import type { renderToStaticMarkup as _renderToStaticMarkup } from 'react-dom/server'
export let renderToStaticMarkup: typeof _renderToStaticMarkup
import('react-dom/server').then((module) => {
renderToStaticMarkup = module.renderToStaticMarkup
})
import { renderToStaticMarkup } from "@/utils/react-dom";
export default function Page() {
return (
<section>
{renderToStaticMarkup(
<h1>
hello <strong>world</strong>
</h1>
)}
</section>
);
} This even preserves the types and I can use The only downside I see is that there is a fraction of a second where |
This Solution by @hdodov worked, But I am facing another issue now with next.js to 'use client', as most of my app components use styled-components so I have to write 'use client', which will not allow than using that inside server api, Looks like next.js is making things hard now, Even ServerStyleSheet will not work on server side, Am i missing anything
My requirement is to generate html templates from existing react components and send html for pdf file generation. |
I would greatly appreciate it if someone could help on this issue.
//client component with some browser context
while converting the client component to HTML-string getting below error (renderToString()) or renderToStaticMarkup Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. So, could some of you please suggest how to convert a client in a server page to pass that updated HTML string to render dynamically in another component using dangerouslySetInnerHTML? thank you. |
Verify canary release
Provide environment information
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 22.1.0: Sun Oct 9 20:14:30 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T8103
Binaries:
Node: 16.18.0
npm: 8.19.2
Yarn: 1.22.19
pnpm: 7.13.6
Relevant packages:
next: 13.0.7-canary.1
eslint-config-next: N/A
react: 18.2.0
react-dom: 18.2.0
Which area(s) of Next.js are affected? (leave empty if unsure)
App directory (appDir: true)
Link to the code that reproduces this issue
https://stackblitz.com/edit/vercel-next-js-arwqsz?file=app%2Fpage.js
To Reproduce
app/page.js
:Run
next dev
and try opening the index page.Describe the Bug
I'm receiving an error message:
Failed to compile.
./app/page.js
You're importing a component that imports react-dom/server. To fix it, render or return the content directly as a Server Component instead for perf and security.
Maybe one of these should be marked as a client entry "use client":
app/page.js
Expected Behavior
Be able to use
react-dom/server
on the server.My usecase it to take some React tree, render it so markup, run it through another postprocessing step which is not aware of anything React specific, and then, return an iframe containing that html.
Contrary to what the error message says, I think there's nothing to fix about importing react-dom/server, and neither should any of this require using the "use client" directive
Which browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
The text was updated successfully, but these errors were encountered: