Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js should warn users when they modify minification settings #8299

Closed
Timer opened this issue Aug 9, 2019 · 2 comments · Fixed by #8337
Closed

Next.js should warn users when they modify minification settings #8299

Timer opened this issue Aug 9, 2019 · 2 comments · Fixed by #8337
Assignees
Milestone

Comments

@Timer
Copy link
Member

Timer commented Aug 9, 2019

We should warn very loudly (or even refuse to build) when the user disables minification for a production build. I think it's best to start with a warning.

We need to check for minimize to be false, or an empty minifier array.


Follow-up: what other properties would be good to ensure users aren't configuring by accident?

@Timer Timer added this to the 9.1.0 milestone Aug 9, 2019
@developit
Copy link
Contributor

I would love to have separate warnings for optimization.minimize and optimization.minifiers. The former is worse since it also disables Webpack's optimizations for NODE_ENV, module concatenation, tree shaking etc.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants