Fix "EXDEV: cross-device link not permitted" error #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why standard passes in my dev environment, but hopefully this fixes the CI errors.
timneutkens
reviewed
Feb 16, 2017
| @@ -7,10 +7,15 @@ export default async function replaceCurrentBuild (dir, buildDir) { | |||
| const oldDir = join(buildDir, '.next.old') | |||
|
|
|||
| try { | |||
| await rename(_dir, oldDir) | |||
| await move(_dir, oldDir) | |||
There was a problem hiding this comment.
The mv package doesn't return a promise but rather expects a callback, in this case await will not wait for the move to complete.
https://github.com/andrewrk/node-mv/blob/master/index.js
There was a problem hiding this comment.
Right, mv doesn't return a promise so that's why I created the move wrapper function and used that. Await works as expected.
There was a problem hiding this comment.
Right 👍 Was reviewing on my phone
Wow, my bad :/
|
This looks really nice. Thanks. |
|
Thanks for fixing! IMO, this justifies an I'm currently using a mac but just bumped into this, as my work and temp folders are on different volumes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this error was introduced in PR #1150. I'm currently developing on Windows from a
D:\drive, while my temp directory is onC:\. It turns out that Node cannot do cross-device renames so a module, calledmv, was created for that very purpose. I swapped in this module in place ofrenamefrommz/fsand I'm now able to build.Here are some references I came across while debugging this:
facebookarchive/nuclide#94
http://stackoverflow.com/q/37153666
http://stackoverflow.com/q/12196163