Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure default fallback values are correct with i18n #23675

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Ensure default fallback values are correct with i18n #23675

merged 1 commit into from
Apr 4, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 4, 2021

This ensures we don't parse the default params when auto-exporting dynamic routes with i18n since the page and path aren't equal when localized. This adds an additional test case to ensure we don't regress on this behavior in the i18n-support test suites.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #23167

@ijjk ijjk added the type: next label Apr 4, 2021
@ijjk
Copy link
Member Author

ijjk commented Apr 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
buildDuration 10.2s 10.3s ⚠️ +94ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +327 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.75 1.788 ⚠️ +0.04
/ avg req/sec 1428.96 1398.59 ⚠️ -30.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.075 1.065 -0.01
/error-in-render avg req/sec 2325.41 2346.99 +21.58
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
buildDuration 11.7s 11.8s ⚠️ +145ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +327 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_error.js 1.36 MB 1.36 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.36 MB 1.36 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.41 MB 1.41 MB ✓
withRouter.js 1.41 MB 1.41 MB ✓
Overall change 6.99 MB 6.99 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
buildDuration 11.8s 12.2s ⚠️ +375ms
nodeModulesSize 45.9 MB 45.9 MB ⚠️ +327 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.803 1.823 ⚠️ +0.02
/ avg req/sec 1386.49 1371.68 ⚠️ -14.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.085 1.093 ⚠️ +0.01
/error-in-render avg req/sec 2303.53 2288.02 ⚠️ -15.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-53316af9..68b6.js gzip 7.04 kB 7.04 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/i18n-fallback-default-values Change
index.html gzip 610 B 610 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "n6fuM_A3kXm-FRE0s8Vm2",
+        "buildId": "VNRkbB8KMqUiS3DluBXq2",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/n6fuM_A3kXm-FRE0s8Vm2/_buildManifest.js"
+      src="/_next/static/VNRkbB8KMqUiS3DluBXq2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/n6fuM_A3kXm-FRE0s8Vm2/_ssgManifest.js"
+      src="/_next/static/VNRkbB8KMqUiS3DluBXq2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "n6fuM_A3kXm-FRE0s8Vm2",
+        "buildId": "VNRkbB8KMqUiS3DluBXq2",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/n6fuM_A3kXm-FRE0s8Vm2/_buildManifest.js"
+      src="/_next/static/VNRkbB8KMqUiS3DluBXq2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/n6fuM_A3kXm-FRE0s8Vm2/_ssgManifest.js"
+      src="/_next/static/VNRkbB8KMqUiS3DluBXq2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "n6fuM_A3kXm-FRE0s8Vm2",
+        "buildId": "VNRkbB8KMqUiS3DluBXq2",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/n6fuM_A3kXm-FRE0s8Vm2/_buildManifest.js"
+      src="/_next/static/VNRkbB8KMqUiS3DluBXq2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/n6fuM_A3kXm-FRE0s8Vm2/_ssgManifest.js"
+      src="/_next/static/VNRkbB8KMqUiS3DluBXq2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 85d288a

@ijjk ijjk marked this pull request as ready for review April 4, 2021 05:22
@kodiakhq kodiakhq bot merged commit 88fd76f into vercel:canary Apr 4, 2021
@ijjk ijjk deleted the fix/i18n-fallback-default-values branch April 4, 2021 14:33
divmain added a commit to divmain/next.js that referenced this pull request Apr 7, 2021
@divmain
Merge remote-tracking branch 'origin/canary' into babel-turbo-mode
7471fb9 
* origin/canary: (36 commits)
  Fixed issue accessing index page of "with-reason-relay" example (vercel#23780)
  upgrade to webpack 5.31.0 (vercel#23776)
  Add note about prefetching (vercel#23732)
  v10.1.4-canary.2
  Ensure no-op export returns without error (vercel#23752)
  Update to with-supertokens example (vercel#23728)
  Ensure fallback rewrites dont match over pages with i18n (vercel#23674)
  Ensure basePath is not applied for external GSSP redirect (vercel#23673)
  Fix webpack5 cache distDir (vercel#23718)
  v10.1.4-canary.1
  Stop mutating `resolvedAsPath` (vercel#23705)
  Font optimization (vercel#21676)
  v10.1.4-canary.0
  Ensure default fallback values are correct with i18n (vercel#23675)
  Fix: Codeblock Syntax Highlighting (vercel#23545)
  fix with-mqtt-js example. (vercel#23636)
  fix with-styled-jsx-plugins example. (vercel#23635)
  fix with-web-worker example. (vercel#23634)
  fixes a part of vercel#23607 remove with-glamor example (vercel#23639)
  v10.1.3
  ...

# Conflicts:
#	packages/next/package.json
#	yarn.lock
@ijjk ijjk mentioned this pull request Apr 19, 2021
Closed
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@ijjk @SokratisVidros
Ensure default fallback values are correct with i18n (vercel#23675)
a8c05f6 
This ensures we don't parse the default params when auto-exporting dynamic routes with i18n since the page and path aren't equal when localized. This adds an additional test case to ensure we don't regress on this behavior in the `i18n-support` test suites.

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added

Fixes: vercel#23167
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default values for fallback dynamic routes differ between development and production
2 participants
@ijjk @shuding