Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade cssnano/postcss version #24034

Merged
merged 3 commits into from
Apr 14, 2021
Merged

fix: upgrade cssnano/postcss version #24034

merged 3 commits into from
Apr 14, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Apr 13, 2021

This PR upgrades CSSNano and PostCSS to v8, fixing various longstanding PostCSS bugs in PostCSS@7. This should yield an overall install size win.

@ijjk
Copy link
Member

ijjk commented Apr 13, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
buildDuration 15.2s 15.6s ⚠️ +427ms
nodeModulesSize 46.9 MB 46.2 MB -712 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.814 2.811 0
/ avg req/sec 888.45 889.21 +0.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.563 1.515 -0.05
/error-in-render avg req/sec 1599 1650.04 +51.04
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
buildDuration 19.1s 19.1s -43ms
nodeModulesSize 46.9 MB 46.2 MB -712 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
buildDuration 15.6s 15.2s -420ms
nodeModulesSize 46.9 MB 46.2 MB -712 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.776 2.783 ⚠️ +0.01
/ avg req/sec 900.52 898.16 ⚠️ -2.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.56 1.624 ⚠️ +0.06
/error-in-render avg req/sec 1602.82 1539.61 ⚠️ -63.21
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "sEeK5UEbuQpNcic0kxZrF",
+        "buildId": "L_tGNPe_qOKRXPdSsFeR2",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/sEeK5UEbuQpNcic0kxZrF/_buildManifest.js"
+      src="/_next/static/L_tGNPe_qOKRXPdSsFeR2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/sEeK5UEbuQpNcic0kxZrF/_ssgManifest.js"
+      src="/_next/static/L_tGNPe_qOKRXPdSsFeR2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "sEeK5UEbuQpNcic0kxZrF",
+        "buildId": "L_tGNPe_qOKRXPdSsFeR2",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/sEeK5UEbuQpNcic0kxZrF/_buildManifest.js"
+      src="/_next/static/L_tGNPe_qOKRXPdSsFeR2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/sEeK5UEbuQpNcic0kxZrF/_ssgManifest.js"
+      src="/_next/static/L_tGNPe_qOKRXPdSsFeR2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "sEeK5UEbuQpNcic0kxZrF",
+        "buildId": "L_tGNPe_qOKRXPdSsFeR2",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/sEeK5UEbuQpNcic0kxZrF/_buildManifest.js"
+      src="/_next/static/L_tGNPe_qOKRXPdSsFeR2/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/sEeK5UEbuQpNcic0kxZrF/_ssgManifest.js"
+      src="/_next/static/L_tGNPe_qOKRXPdSsFeR2/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f94d670

@Timer Timer marked this pull request as ready for review April 14, 2021 07:44
@ijjk
Copy link
Member

ijjk commented Apr 14, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
buildDuration 11.8s 11.8s ⚠️ +67ms
nodeModulesSize 46.9 MB 46.2 MB -712 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.101 2.063 -0.04
/ avg req/sec 1189.96 1212.09 +22.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.084 1.072 -0.01
/error-in-render avg req/sec 2306.9 2331.83 +24.93
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
buildDuration 14.9s 14.6s -377ms
nodeModulesSize 46.9 MB 46.2 MB -712 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -2 B
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB -2 B
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
buildDuration 11.8s 11.8s -18ms
nodeModulesSize 46.9 MB 46.2 MB -712 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.086 2.035 -0.05
/ avg req/sec 1198.66 1228.29 +29.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.06 1.084 ⚠️ +0.02
/error-in-render avg req/sec 2359.57 2306.22 ⚠️ -53.35
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9c11a899..1178.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js deps/upgrade-postcss Change
index.html gzip 609 B 609 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "8m58C7xyIpazV4RJ2tLtl",
+        "buildId": "Tbg0j5658-_qkWazlVyQk",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8m58C7xyIpazV4RJ2tLtl/_buildManifest.js"
+      src="/_next/static/Tbg0j5658-_qkWazlVyQk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8m58C7xyIpazV4RJ2tLtl/_ssgManifest.js"
+      src="/_next/static/Tbg0j5658-_qkWazlVyQk/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "8m58C7xyIpazV4RJ2tLtl",
+        "buildId": "Tbg0j5658-_qkWazlVyQk",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8m58C7xyIpazV4RJ2tLtl/_buildManifest.js"
+      src="/_next/static/Tbg0j5658-_qkWazlVyQk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8m58C7xyIpazV4RJ2tLtl/_ssgManifest.js"
+      src="/_next/static/Tbg0j5658-_qkWazlVyQk/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "8m58C7xyIpazV4RJ2tLtl",
+        "buildId": "Tbg0j5658-_qkWazlVyQk",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8m58C7xyIpazV4RJ2tLtl/_buildManifest.js"
+      src="/_next/static/Tbg0j5658-_qkWazlVyQk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8m58C7xyIpazV4RJ2tLtl/_ssgManifest.js"
+      src="/_next/static/Tbg0j5658-_qkWazlVyQk/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ea3296c

@kodiakhq kodiakhq bot merged commit 8809358 into vercel:canary Apr 14, 2021
@ijjk ijjk deleted the deps/upgrade-postcss branch April 14, 2021 23:32
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@Timer @SokratisVidros
fix: upgrade cssnano/postcss version (vercel#24034)
0cfd3fc 
This PR upgrades CSSNano and PostCSS to v8, fixing various longstanding PostCSS bugs in PostCSS@7. This should yield an overall install size win.
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @ijjk @timneutkens