Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add tracing to with-sentry example #30401

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

lobsterkatie
Copy link
Contributor

@lobsterkatie lobsterkatie commented Oct 27, 2021

This adds tracing to the with-sentry example app. Key changes:

  • Tracing is enabled by setting tracesSampleRate in both Sentry.init() calls
  • Text is added to the app homepage explaining the tracing which will take place in the existing example routes
  • Manual tracing is added to one of the examples

Dependencies have also been updated:

  • Bump to the upcoming version of @sentry/nextjs to take advantage of a few fixes which will be included there
  • Restrict next to not include Next 12 for the moment, as some of the new features might cause problems with the current version of the SDK. This can be updated once we get a chance to test the compatibility of the two.

H/t @iker-barriocanal for doing most of the work here

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 27, 2021
@sambacha
Copy link

sambacha commented Oct 28, 2021

@lobsterkatie lobsterkatie marked this pull request as ready for review November 8, 2021 14:49
@lobsterkatie
Copy link
Contributor Author

We will likely bump our SDK version here again in the nearish future (this week, I'd expect). Not sure if y'all would rather merge this now and do that in a separate PR, or hang on until we do that. This is good to go, though, otherwise.

@lobsterkatie lobsterkatie force-pushed the kmclb-add-tracing-to-with-sentry branch from af5beb6 to 41d87cc Compare November 29, 2021 14:44
@lobsterkatie
Copy link
Contributor Author

Updated the SDK version, so this is ready, if someone wouldn’t mind reviewing it, please?

cc @ijjk @leerob

@leerob leerob merged commit c03fa72 into vercel:canary Nov 29, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-tracing-to-with-sentry branch January 28, 2022 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants