Fix with-amp example #3153
Merged
Fix with-amp example #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React v16 supports invalid DOM attributes now. ReactInjection and DOMProperty throws an error. Reference: #3152
|
Hi @timneutkens! There are some examples with errors, some of them throw a compatibility error between React < v16 and Next v4, and there are issues like this one, with unknown DOM attributes. Do you think that all examples should update to I see that you updated many examples in #3113, but some were not updated. |
|
If you could check them out that'd be great, I just did a simple search/replace |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React v16 supports invalid DOM attributes now.
ReactInjection and DOMProperty throws an error.
Reference: #3152