-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swc_core
to v0.87.28
#60876
Merged
Merged
Update swc_core
to v0.87.28
#60876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the Turbopack team.
type: next
labels
Jan 19, 2024
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
kdy1
force-pushed
the
kdy1/swc-core-87-3
branch
from
January 21, 2024 07:14
5cc4835
to
747d103
Compare
Failing test suitesCommit: 1f5c504
Expand output● Prerender › should not error when rewriting to fallback dynamic SSG page
Read more about building and testing Next.js in contributing.md. |
kdy1
force-pushed
the
kdy1/swc-core-87-3
branch
from
January 22, 2024 09:19
f5c2bac
to
c235e1e
Compare
kdy1
force-pushed
the
kdy1/swc-core-87-3
branch
from
January 23, 2024 01:40
6718070
to
b89db5a
Compare
kdy1
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
January 23, 2024 02:43
1 task
kdy1
force-pushed
the
kdy1/swc-core-87-3
branch
from
January 24, 2024 03:44
eb62f00
to
fc71e45
Compare
sokra
reviewed
Jan 24, 2024
@@ -226,15 +226,21 @@ export default function (next: NextInstance, render, fetch, ctx) { | |||
const styleId = $('#blue-box').attr('class') | |||
const style = $('style') | |||
|
|||
expect(style.text().includes(`p.${styleId}{color:blue`)).toBeTruthy() | |||
expect( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nicer to read with toMatch
sokra
approved these changes
Jan 24, 2024
kdy1
added a commit
to vercel/turborepo
that referenced
this pull request
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the Turbopack team.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turbopack
swc_core
tov0.87.28
turborepo#7027What?
Update swc crates
Why?
Required for #57718.
styled-jsx
crate now have a hook to transform CSS code using a Rust-side APIHow?
Fixes #57718
Closes PACK-2256