Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to trace node_modules containing symlinks (yarn workspaces) #14

Closed
styfle opened this issue Jul 12, 2019 · 0 comments · Fixed by #15
Closed

Failing to trace node_modules containing symlinks (yarn workspaces) #14

styfle opened this issue Jul 12, 2019 · 0 comments · Fixed by #15
Assignees
Labels
bug Something isn't working

Comments

@styfle
Copy link
Member

styfle commented Jul 12, 2019

The issue is that node-file-trace is following the symlinks is node_modules instead of returning them in the fileList output.

Steps to reproduce

git clone https://github.com/mattste/now-node-builder-issue
cd now-node-builder-issue
yarn install
cat > build.js <<- "EOF"
const nodeFileTrace = require('@zeit/node-file-trace');

nodeFileTrace(['project-a/index.js'], {
  base: process.cwd(),
  filterBase: true,
  ts: true,
}).then(({fileList}) => {
  console.log(fileList.join('\n'));
});

EOF

node build.js

Actual

        project-a/index.js
        project-b/index.js

Expected

        project-a/index.js
        project-b/index.js
        node_modules/project-a/index.js

cc @guybedford

@styfle styfle added the bug Something isn't working label Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants