resolve v1.21 breaks bundled graceful-fs in nextjs

[benbender]

As debugged in browserify/resolve#264, resolve v1.21 introduces a change in behaviour which in turn breaks graceful-fs. A fix in graceful-fs is released with v4.2.9, but nft seems to be bundling a lower version.

As this potentially breaks a lot of next.js babel-setups (see f.e. vercel/next.js#33003), a rerelease with the fixed graceful-fs-package would be great!

[ljharb]

It would also be ideal if this package didn't bundle requireable things at all, so that downstream consumers benefited from automatic in-range version updates for bugfixes (like this one) and security fixes.

[styfle]

Can you share the steps to reproduce the issue?

[benbender]

"You could use https://github.com/vercel/next.js/tree/canary/examples/with-babel-macros as a quite simple reproduction for testing. Simply clone it and run "npm install && npm dev" to see the error in the browser."

as written here browserify/resolve#264 (comment)

[ljharb]

Note that if you update graceful-fs and recreate the bundle, that should be sufficient to solve the short-term problem.

[styfle]

So this isn't an issue with nft which doesn't rely on resolve?

[ljharb]

ahhh right, this was filed on the wrong repo (about relying on graceful-fs, not on resolve). It's an issue with the index.js file in https://unpkg.com/browse/next@12.0.7/dist/compiled/@vercel/nft/ which bundles the broken graceful-fs instead of requiring it.

This should be closed and filed instead of the repo for the next package.

[styfle]

Upon further investigation, I think the issue is the global patch here:

nft/src/node-file-trace.ts

Line 16 in f146d3c

gracefulify(fs);

I think we can change nft to call the read/write methods directly instead of doing a global patch like this.

[ljharb]

That would also be a great long-term solution for nft :-)

(altho it'd still require next to update its bundle and/or stop bundling third party deps)