-
Notifications
You must be signed in to change notification settings - Fork 1k
Possibility to reduce packages size by 4x #50
Comments
@pi0 Do you see any potential impact your NodeApp's performance? I'm considering this for my Ghost installation. Cheers! |
@pi0 How did you do that compression? could you provide an example? |
Hi, as we're talking about bundle size, does If I apply something like prepack + uglify before packaging, will my final packaged app be lighter? |
running |
The idea behind pkg is to introduce minimal changes over original nodejs. Btw, if you run |
Hi. Sorry answering late :) @pascalandy About performance impact: I think if we do extraction on startup, it may only affect startup time and not run-time itself. @roccomuso My first test was just using tar! But it would be easy adding self-extract bits on binary's head.(exe inside exe) @anmonteiro About js minification, pkg is absolutely not webpack! And i don't think this would help a lot, main size suffer is from Node.js binary itself. And we could just make a blind compression on the whole things. (Also @igorklopov is correct about |
Some interesting projects we could get idea/ use: |
@anmonteiro That is very weird. Why is this happening? |
|
Oh hrm, sorry for the bad suggestion. I use |
Referencing #121 for UPX issue (https://github.com/upx/upx). |
Btw I wrote a node.js wrapper for UPX, https://github.com/roccomuso/upx |
What about the idea of using libsquash similar to https://github.com/pmq20/node-packer ? upx may cause false positives on some antivirus detection |
It seems that the nexe owner gets a clue on this: nexe/nexe#366 (comment) He uses UPX over node.js itself ( $ pkg -t node8-x64 app.js -o dist/app
> pkg@4.3.0
assert.js:42
throw new errors.AssertionError({
^
AssertionError [ERR_ASSERTION]: Placeholder for not found
at injectPlaceholder (~/project/node_modules/pkg/lib-es5/producer.js:217:38)
at injectPlaceholders (~/project/node_modules/pkg/lib-es5/producer.js:236:3)
at ~/project/node_modules/pkg/lib-es5/producer.js:158:9
at FSReqWrap.oncomplete (fs.js:135:15) Any idea? |
@Clement-TS I got the same error trying to compress the node binary before using |
Tried today with upx 3.95 on Linux and the problem still persists. |
My windows .exe build size reduced 7.xx MB from 21.xx MB with upx, thanks for mentioning it 🌟 |
EDIT: Here is an example of how I use |
Can you say what parameters you used to pack Windows .exe? I tried (UPX 3.95 Win10x64)
but the executable is failing to start. |
I didn't use any special flags. Just dragged my .exe and dropped over upx. Thats what I did |
Thanks, but just Drag&Drop didn't work for me. I'll try packaging with Nexe later, I've read somewhere that they were natively optimised for upx (and support customising .exe file icon out of the box) |
Hey, any update on the matter? UPX + pkg doesn't seems to work so far and that would be really neat if it was. |
FWIW: Just tested here using gzexe (Linux) and works good. From 134Mb to 43MB, and i good only 1s performance penalty on load (did not test other runtime operations). |
Any progress here? When I compress |
Regarding UPX: As it is now, the To get pkg to work with upx, one approach could be to update the That would still result in the js code itself being uncompressed, however, it would at least be able to shrink the nodejs binary by a fair amount. Another approach could be to change the way the js payload is stored in the final binary so that it is accessible by the code in the Edit: because it will segfault if the length of that string changes. :) |
I've just checked a built binary in a hex editor and discovered that
as well as
Is there any reason I'm missing for why these two positions are stored at all? |
Hi! Just done a quick test on windows builds. Bundle size can be reduced from 24,964 KB to 6,646 KB (3.75x smaller) with doing simple xz compression. This may even help more when having more npm dependencies. Adding this option may be super useful for small and embedded CLI/Webservers :) I've just opened this discussion before going further to know others idea on this.
UPDATE: To be clear, this topic and what i am talking about is SFX packages not js minification & optimizing.
The text was updated successfully, but these errors were encountered: