-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generates unencoded attribute values #291
Labels
Comments
Hey! I'd like to work on this one. Are we okay with the naive solution of encoding only limited set of characters like |
shuding
pushed a commit
that referenced
this issue
Aug 11, 2023
🎉 This issue has been resolved in version 0.10.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sahithyandev
pushed a commit
to sahithyandev/satori
that referenced
this issue
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Description / Observed Behavior
Satori generates attribute values from inline CSS without encoding some characters (particularly
"
and<
) (in certain cases?).This makes SVG parsers (browsers, resvg) crash on the file.
Expected Behavior
Encode (at least)
"
and<
in attribute values.Likely also
&
for character references (&
).Reproduction
Yields:
Note particularly the
href
:Additional Context
latest
Here’s some code on how I serialize XML: https://github.com/syntax-tree/xast-util-to-xml. Not sure what’s being used here. If it’s a custom AST like structure, perhaps
xast
might help!The text was updated successfully, but these errors were encountered: