Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken alignment for text with textWrap: 'balance' if text doesn't contain whitespace #498

Open
dimaMachina opened this issue May 30, 2023 · 3 comments · May be fixed by #499
Open

broken alignment for text with textWrap: 'balance' if text doesn't contain whitespace #498

dimaMachina opened this issue May 30, 2023 · 3 comments · May be fixed by #499

Comments

@dimaMachina
Copy link
Contributor

Hey @shuding, found some bug with textWrap: 'balance'! also this bug happens starting from v0.4.0 when textWrap: 'balance' was introduced

Bug report

Description / Observed Behavior

          <span tw="font-bold text-5xl" style={{ textWrap: 'balance', background: 'red' }}>
            {title}
          </span>

Expected Behavior

below text without textWrap: 'balance'

image

Actual

image

Reproduction

Create a shareable reproduction link for the issue using https://og-playground.vercel.app/?share=vZI9TsQwEIWvMpo61qYACRmWDokDING4sePJz-K1I2dCEkW5Bx0n4G4cgWQThITYBgka_2je8_vGmhGzYAkl3tjqGbjbK8wd9bAsIgsOOpG3zoEpRBGJvLhIU4W3ygN8cxzahqt8EBl5prj5Nuksbmrt1yNspuBZmOAsMPUsLvtZ_CloeHC0H8dT6THqWoJCo532GSlMwOjsqYih9XYpRLIKYZpW9xYIcB-OtIXvlvQVejdT_xL_PPcX8M9kf8f0_18K768vb2d7WPdr5THBUHMVfINyxK6yXKK8StMES6qKklHOk5SgJdMWKHPtGkqQjuFQPQz1MpDcnW7zO0tbd0dDFiXHlqYEWZtZUZJzoQvRWZw-AA

Additional Context

Satori: 0.9.1

⚠️ ⚠️ ⚠️ Note this happens only if there is no whitespace character
@dimaMachina dimaMachina linked a pull request May 30, 2023 that will close this issue
Open
@joeporpeglia
Copy link

Adding wordBreak: 'break-word' prevents the text from clipping and fixes the layout issue. Not an ideal workaround, but maybe textWrap: 'balance' was only intended to work with break-word / break-all?

@eeberhart40
Copy link

This is still an issue

@philwolstenholme philwolstenholme mentioned this issue Mar 5, 2024
Closed
@kentcdodds
Copy link

Confirmed this is still an issue.

kentcdodds added a commit to epicweb-dev/epicshop that referenced this issue Jun 25, 2024
@kentcdodds
fix(og): center things properly
a57f74e 
vercel/satori#498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@joeporpeglia @kentcdodds @dimaMachina @eeberhart40