Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satori does not work with components which are using forwardRef #600

Open
sdorra opened this issue Mar 7, 2024 · 2 comments · May be fixed by #601
Open

Satori does not work with components which are using forwardRef #600

sdorra opened this issue Mar 7, 2024 · 2 comments · May be fixed by #601

Comments

@sdorra
Copy link

sdorra commented Mar 7, 2024

Bug report

Description / Observed Behavior

Satori does not render components which are using forwardedRef. For example FontAwesomeIcon.

Expected Behavior

Satori should render components which are using React.forwardRef.

Reproduction

The following demo uses the latest next.js canary and should show 👋 Hello World 👋, instead it renders only World 👋 the 👋 Hello uses a forwardRed and is not rendered.

https://github.com/sdorra/og-with-forwardRef
@sdorra
Copy link
Author

sdorra commented Mar 7, 2024

I've already opened an issue at next.js, but i think it is more a satori bug than a next.js one.

shuding added a commit that referenced this issue Mar 11, 2024
@shuding
fix #600
94c4484
@shuding shuding linked a pull request Mar 11, 2024 that will close this issue
Open
@Yovach
Copy link

Yovach commented Dec 11, 2024

This issue also applies to this one #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support forwardRef wrapped component vercel/satori
2 participants
@sdorra @Yovach