Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it alive? #688

Closed
artalar opened this issue Dec 14, 2020 · 5 comments
Closed

Is it alive? #688

artalar opened this issue Dec 14, 2020 · 5 comments

Comments

@artalar
Copy link

artalar commented Dec 14, 2020

Hi there, styled-jsx is an interesting lib with good API, it recommended by official docs of next.js and already integrated with it (also hosted in the Vercel GH org).
But it looks a little neglected. I was created #650 and #651 a long time ago but still have no reactions. This repo has other issues without any reactions. Why it happened, is it a lack of maintainers?

@artalar
Copy link
Author

artalar commented Dec 17, 2020

@rauchg, @nkzawa, @leo, @giuseppeg pay attention please

@jaydenseric
Copy link
Contributor

@artalar sadly, this project is not adequately maintained to be relied upon anymore. I've put many hours into into high effort suggestions and PR's that fix critical bugs, only for them to languish for months without a merge or sometimes even review:

These important suggestions haven't been actioned in a year:

I really gave styled-jsx my best shot and have pushed it to its limits over the years, but due to bugs blocking things I need to do at this point it makes the most sense to refactor projects away from styled-jsx to Emotion and update my UI library to use Emotion (as well as supporting Styled Components via an abstraction). Emotion will probably have bugs too from time to time, but at least they have good velocity and actively maintain the project.

@theoludwig
Copy link
Contributor

theoludwig commented Jan 9, 2021

I find out that styled-jsx is the best css-in-js solution for styling react components.
I would love to maintain the project if there are really no one having enough time to maintain the library, because I don't want to say goodbye to styled-jsx.

I never liked styled-component solution for example or others libraries like emotion etc. I always use styled-jsx since it's builtin in Next.js, it has a really good api and everything but styled-jsx has real issues that should be fix now, maybe @giuseppeg could add motivated collaborators to the project.

Also to improve the project further, we could deprecate @types/styled-jsx, and instead provide types directly in this package or even better, we could rewrite the package in TypeScript, we could benefit a lot from this. I could open a PR and work on this if wanted.

@artalar
Copy link
Author

artalar commented Jan 12, 2021

I hope we will see some movement in the near future, I don't want the death of styled-jsx, but the current silens of mainteners looks not good.

P.S. @divlo currently u haven't the rights to accept PRs?

@Timer
Copy link
Member

Timer commented Jan 12, 2021

Hi everyone! This package is still alive and we fix issues as they come up if they relate to Next.js.

Please open any bugs you may be experiencing on the Next.js issue tracker specifically, which will give them more visibility.

RFCs should also exist as a Next.js discussion as that'd draw the most attention to get the upvotes necessary to implement the feature.

I'll close this issue, but please CC me on any issues that need attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants