If revalidateOnFocus and suspense are used together, when an error occurs onfoucs listeners are never cleaned up

[gaoxiaoliangz]

Bug report

Description / Observed Behavior

If revalidateOnFocus and suspense are used together, when an error occurs onfoucs listeners are never cleaned up

Expected Behavior

When errors are caught in error boundary, onfocus listeners are cleaned up, a page refocus never triggers a revalidation.

Additional Context

SWR version: 0.5.5

[promer94]

Hi, could you please provide a codesandbox repro ?

FYI: https://codesandbox.io/s/suspense-focus-5c0zf?file=/src/App.js
This seems works

[shuding]

I think this is tricky – when a component throws and gets caught by the error boundary, the hooks will be unmounted so you can't re-render anymore. The same applies to a Suspense boundary as well.

This needs more discussion, also related to #168.