-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(filter): dependencies filter should match transitive deps #7886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
gsoltis
approved these changes
Apr 2, 2024
tknickman
approved these changes
Apr 2, 2024
🟢 CI successful 🟢Thanks |
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced Jun 2, 2024
This was referenced Jun 5, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug from port where
...
filter would only select immediate dependencies.In Go we used
graph.Ancestors
which performs a full DFS, not just immediate ancestors. This PR updates so we do the same in Rust.Testing Instructions
Added unit test that uses
...
filter on a project with transitive dependencies.We already have test cases for the reverse case of including reverse dependants
For good measure did a manual check in repo with following dep chain:
docs -> @repo/ui -> foo
Closes TURBO-2749