Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add removal warning to deprecated flags #7890

Merged
merged 2 commits into from
Apr 15, 2024
Merged

chore: add removal warning to deprecated flags #7890

merged 2 commits into from
Apr 15, 2024

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Apr 2, 2024 •
edited by padmaia
Loading

Description

TSIA

Testing Instructions

Manual test that warning appears on usage:

[0 olszewski@chriss-mbp] /tmp/dep-warn $ turbo_dev --skip-infer run build --scope web --no-deps --trace=trace.foo
 WARNING  --trace is deprecated and will be removed in 2.0
 WARNING  --scope is deprecated and will be removed in 2.0
 WARNING  --no-deps is deprecated and will be removed in 2.0
...

Closes TURBO-2751

@chris-olszewski chris-olszewski marked this pull request as ready for review April 2, 2024 19:16
@chris-olszewski chris-olszewski requested a review from a team as a code owner April 2, 2024 19:16
@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 3:43pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@chris-olszewski chris-olszewski enabled auto-merge (squash) April 2, 2024 19:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@chris-olszewski chris-olszewski merged commit 58f9159 into main Apr 15, 2024
55 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_warn_on_scope_usage branch April 15, 2024 16:12
This was referenced May 18, 2024
Open
Open
Open
Open
This was referenced May 24, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced May 31, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 8, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-olszewski @tknickman