Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on with-docker #7915

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Bug fix on with-docker #7915

merged 14 commits into from
Apr 22, 2024

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Apr 8, 2024

Description

  • moved content of @repo/jest-presets package one level up and out of /jest directory for better accessibility. (in order to import the jest presets like @repo/jest-presets/node instead of @repo/jest-presets/jest/node )
  • added @types/node to @repo/logger package and applied it in types of tsconfig.json to fix the error:
Cannot find name 'global'.
jest.spyOn(global.console, "log");
            ^^^^
  • removed duplicate tsconfig.json from tests as they are not needed.
  • added "DOM" to lib of @repo/logger to fix the error:
Cannot find name 'console'. Do you need to change your target library? 
Try changing the 'lib' compiler option to include 'dom'.
  • added type to the createServer function to fix the error:
The inferred type of 'createServer' cannot be named without a reference to 
'.pnpm/@types+express-serve-static-core@4.19.0/node_modules/@types/express-serve-static-core'. 
This is likely not portable. A type annotation is necessary.
  • replaced toBeCalled as it's been deprecated
  • change healthz to status for consistency between examples and also to fix the typo of healthz
  • improved React imports by importing ChangeEvent and FormEvent instead of using them as React.ChangeEvent and React.FormEvent
  • update the main README.md to have updated apps and packages informations

Testing Instructions

Running npx create-turbo@latest -e with-docker and then both pnpm dev and pnpm test should work fine and tests should pass.

@zsh77 zsh77 requested review from anthonyshew and a team as code owners April 8, 2024 16:41
@zsh77 zsh77 requested a review from arlyon April 8, 2024 16:42
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Apr 8, 2024
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 4:57am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 4:57am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am
rust-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 4:57am

@zsh77 zsh77 changed the title Bug fix on with docker Bug fix on with-docker Apr 8, 2024
Copy link

vercel bot commented Apr 8, 2024

@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Apr 8, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8af4043

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love all the cleanup! Thank you.

@anthonyshew anthonyshew merged commit 71a74b8 into vercel:main Apr 22, 2024
49 checks passed
@zsh77 zsh77 deleted the bug-fix-on-with-docker branch April 22, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants