fix(pnpm): correctly parse dependency paths with nested peer dependecies #8003
+48
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
tknickman
approved these changes
Apr 19, 2024
| @@ -170,9 +192,13 @@ mod tests { | |||
| #[test_case("foo@1.0.0", DepPath::new("foo", "1.0.0") ; "basic v7")] | |||
| #[test_case("@scope/foo@1.0.0", DepPath::new("@scope/foo", "1.0.0") ; "scope v7")] | |||
| #[test_case("foo@1.0.0(bar@1.2.3)", DepPath::new("foo", "1.0.0").with_peer_suffix(Some("(bar@1.2.3)")) ; "peer v7")] | |||
| #[test_case( | |||
| "eslint-module-utils@2.8.0(@typescript-eslint/parser@6.12.0(eslint@8.57.0)(typescript@5.3.3))", | |||
There was a problem hiding this comment.
This is an abridged example the full christian name is eslint-module-utils@2.8.0(@typescript-eslint/parser@6.12.0(eslint@8.57.0)(typescript@5.3.3))(eslint-import-resolver-node@0.3.9)(eslint-import-resolver-typescript@3.6.1(@typescript-eslint/parser@6.12.0(eslint@8.57.0)(typescript@5.3.3))(eslint-plugin-import@2.29.0)(eslint@8.57.0))(eslint@8.57.0)
|
|
||
| let (version, peer_suffix) = match version.find('(') { | ||
| Some(paren_index) if version.ends_with(')') => { | ||
| // TODO: safety of the split? |
There was a problem hiding this comment.
Oops, old comment. I had an off by one error previously 😅
🟢 CI successful 🟢Thanks |
1 task
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced May 31, 2024
This was referenced Jun 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should address the reported issues in #7993
I missed a change to the dependency path format where nested peer dependencies are now shown e.g. if a has peer dependency b and b has peer dependency c, then the resulting dependency path will be
a@1.0.0(b@1.0.0(c@1.0.0)).Not sure when dependency path parsing got simplified, but I believe I missed the host segment getting dropped which greatly simplifies the format. The new parsing logic is a faithful port of the current JS parsing code: https://github.com/pnpm/pnpm/blob/main/packages/dependency-path/src/index.ts#L91
Testing Instructions
Added unit test for parsing a dependency path that contains a nested peer dependency. Existing test suite.
Closes TURBO-2848