chore: Improved errors for watch mode #8016
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
changed the base branch from
nicholasyang/persistent-tasks
to
main
NicholasLYang
force-pushed
the
nicholasyang/better-errors
branch
from
54348f9
to
b31dfdc
Compare
NicholasLYang
changed the title
tknickman
approved these changes
Apr 22, 2024
mehulkar
approved these changes
Apr 22, 2024
| DaemonError::VersionMismatch(Some(status.message().to_owned())) | ||
| Code::FailedPrecondition => DaemonError::VersionMismatch(status.message().to_owned()), | ||
| Code::Unimplemented => { | ||
| DaemonError::VersionMismatch("rpc not implemented on daemon".to_string()) |
There was a problem hiding this comment.
does rpc need to be capitalized?
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced Jun 2, 2024
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our error messages were a little opaque for watch mode. This threads the diagnostic code through the watch mode errors and adds some help text.
Testing Instructions
Closes TURBO-2856