Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new TUI does not resize on window resize #8477

Closed
1 task done
huilensolis opened this issue Jun 13, 2024 · 5 comments
Closed
1 task done

new TUI does not resize on window resize #8477

huilensolis opened this issue Jun 13, 2024 · 5 comments
Labels
kind: bug Something isn't working

Comments

@huilensolis
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

not necessary, just create a monorepo and run turbo <script>

What package manager are you using / does the bug impact?

npm, pnpm, Yarn v1, Yarn v2/v3/v4 (node_modules linker only)

What operating system are you using?

Linux

Which canary version will you have in your reproduction?

2.0.2

Describe the Bug

if you run a script on your terminal with turbo <script> and resize the window, the TUI will not resize.

if you have a workspace divided in two terminal windows, in one you run turbo <script> and then open the terminal with turborepo in full screen, the TUI will not adapt to the new screen width

Expected Behavior

to update its width as the window resizes

To Reproduce

create a new monorepo
create a script that doesn't exit interactive mode

run the script
resize window

see the broken TUI

Additional context

No response

@huilensolis huilensolis added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Jun 13, 2024
@chris-olszewski chris-olszewski removed the needs: triage New issues get this label. Remove it after triage label Jun 13, 2024
@MickL
Copy link

MickL commented Jun 15, 2024

I experience the same in iTerm on macOS

@AndreaPontrandolfo
Copy link

AndreaPontrandolfo commented Jun 18, 2024

For me it's different.
With the old TUI, the TUI wasn't resizing along the terminal pane. Same as you are describing.
BUT with the new TUI i'm experiencing a different behaviour.
If i start a command with a little window, the TUI will not be present, it will just revert the turborepo process to behave as interactive: false (like, it's working exactly as before the TUI got introduced).
If i start the command with a taller window, the new TUI takes over and works perfectly.

Environment:
MacOS
VSCode integrated terminal

@AndreaPontrandolfo
Copy link

Just noticed that actually this is an intended behavior made in #8457.
Why was this decision taken? This doesn't look right.

@anthonyshew anthonyshew linked a pull request Jun 24, 2024 that will close this issue
@chris-olszewski
Copy link
Member

@AndreaPontrandolfo This decision was made due to the TUI requiring a certain minimum amount of area. Attempting to run the TUI in a terminal with less area results in an incorrect render or a crash.

@chris-olszewski
Copy link
Member

Closing this as it was implemented in #8996 and first released in 2.0.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants