Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does --no-daemon really work? #9401

Closed
1 task done
JonnyBurger opened this issue Nov 7, 2024 · 2 comments · Fixed by #9407
Closed
1 task done

Does --no-daemon really work? #9401

JonnyBurger opened this issue Nov 7, 2024 · 2 comments · Fixed by #9407
Labels
kind: bug Something isn't working

Comments

@JonnyBurger
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

github.com/remotion-dev/remotion

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

2.2.4-canary.8

Describe the Bug

I try to disable the daemon:

turbo.json: {"daemon": false}
and run a watch command with --no-daemon

bunx turbo --no-daemon -vv watch make

Yet, two processes get created (none running before):

image

and the logs say it uses the daemon:

2024-11-07T09:21:23.851+0100 [DEBUG] turborepo_lib::daemon::connector: got daemon with pid: 53043
2024-11-07T09:21:23.852+0100 [DEBUG] turborepo_lib::daemon::connector: connecting to socket: /var/folders/hs/mbxg3j_55ls1b_dhn50w32t00000gn/T/turbod/b56db5bdb8c4c0f1/turbod.sock
2024-11-07T09:21:23.852+0100 [DEBUG] turborepo_lib::daemon::connector: connected in 497µs
2024-11-07T09:21:23.852+0100 [DEBUG] turborepo_lib::run::package_discovery: discovering packages using daemon

etc.

And I get the dreaded failed to discover packages error pretty often, which is why I want to for now disable the daemon

Expected Behavior

No daemon should be started

If this is intended and the flag doesn't work with watch mode, this should be documented

To Reproduce

Clone repo above
Run pnpm i && bunx turbo --no-daemon watch make

Additional context

This behavior goes at least back to 2.1.1 which also has this behavior

@JonnyBurger JonnyBurger added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Nov 7, 2024
@JonnyBurger JonnyBurger changed the title Does --no-daemon really work Does --no-daemon really work? Nov 7, 2024
@JoCa96
Copy link

JoCa96 commented Nov 7, 2024

Noticed the same in regard to #9394

@chris-olszewski
Copy link
Member

turbo watch requires the daemon so we have access to a persistent file watcher. #9407 will add a warning that we're ignoring any requests to disable the daemon when performing a watch.

@chris-olszewski chris-olszewski removed the needs: triage New issues get this label. Remove it after triage label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants