More fluent GraphTraversal API #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
Benchmark for ce22e68Click to view benchmark
|
alexkirsz
commented
Apr 17, 2023
Comment on lines
+23
to
+25
| let completions = NonDeterministic::new() | ||
| .skip_duplicates() | ||
| .visit([root], get_referenced_assets) |
There was a problem hiding this comment.
This is the difference in interface: no more type wrangling to create the traversal.
sokra
reviewed
Apr 17, 2023
| @@ -66,9 +90,9 @@ where | |||
| } | |||
| } | |||
There was a problem hiding this comment.
SkipDuplicates could implement skip_duplicates and return self
There was a problem hiding this comment.
With the way the traits are set up, this would require specialization, so I'm going to skip this for now.
sokra
reviewed
Apr 17, 2023
crates/turbopack-node/src/lib.rs
Outdated
| .await | ||
| .completed()? | ||
| .into_inner(); | ||
| let graph = ReverseTopological::<Type>::new() |
There was a problem hiding this comment.
Suggested change
| let graph = ReverseTopological::<Type>::new() | |
| let graph = ReverseTopological::new() |
It should be able to infer that, shouldn't it?
sokra
approved these changes
Apr 17, 2023
alexkirsz
force-pushed
the
alexkirsz/graph-refactor
branch
from
de35f0e to
b9cfb3b
Compare
alexkirsz
added
the
pr: automerge
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 1, 2023
See vercel/turborepo#4598 ### Turbopack changes * vercel/turborepo#4754 <!-- Justin Ridgewell - Match TS's extends resolution algorithm --> * vercel/turborepo#4598 <!-- Alex Kirszenberg - More fluent GraphTraversal API --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This PR refactors the API of `GraphTraversal` to be more fluent, and less magical. It should make it easier to use and understand. Had this in store from trying to debug a lifetime issue in another branch. ### Testing Instructions Surface-level change. Next.js PR: https://github.com/vercel/turbo/pulls/alexkirsz
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This PR refactors the API of `GraphTraversal` to be more fluent, and less magical. It should make it easier to use and understand. Had this in store from trying to debug a lifetime issue in another branch. ### Testing Instructions Surface-level change. Next.js PR: https://github.com/vercel/turbo/pulls/alexkirsz
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This PR refactors the API of `GraphTraversal` to be more fluent, and less magical. It should make it easier to use and understand. Had this in store from trying to debug a lifetime issue in another branch. ### Testing Instructions Surface-level change. Next.js PR: https://github.com/vercel/turbo/pulls/alexkirsz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the API of
GraphTraversalto be more fluent, and less magical. It should make it easier to use and understand. Had this in store from trying to debug a lifetime issue in another branch.Testing Instructions
Surface-level change.
Next.js PR: https://github.com/vercel/turbo/pulls/alexkirsz