From c504e8e4b031ad56a6766ae0f74128862b2f2f94 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 30 Jul 2024 08:30:38 -0600 Subject: [PATCH 1/3] Make FS error more clear. --- crates/turborepo-lib/src/commands/prune.rs | 2 +- .../packages/ui/src/link/index.test.tsx | 11 -------- .../packages/ui/src/link/index.tsx | 25 ------------------- 3 files changed, 1 insertion(+), 37 deletions(-) delete mode 100644 examples/kitchen-sink/packages/ui/src/link/index.test.tsx delete mode 100644 examples/kitchen-sink/packages/ui/src/link/index.tsx diff --git a/crates/turborepo-lib/src/commands/prune.rs b/crates/turborepo-lib/src/commands/prune.rs index 9459164233b7b..d6715d7723a92 100644 --- a/crates/turborepo-lib/src/commands/prune.rs +++ b/crates/turborepo-lib/src/commands/prune.rs @@ -24,7 +24,7 @@ pub const DEFAULT_OUTPUT_DIR: &str = "out"; pub enum Error { #[error("io error while pruning: {0}")] Io(#[from] std::io::Error), - #[error("fs error while pruning: {0}")] + #[error("File system error while pruning. The error from the operating system was: {0}")] Fs(#[from] turborepo_fs::Error), #[error("json error while pruning: {0}")] Json(#[from] serde_json::Error), diff --git a/examples/kitchen-sink/packages/ui/src/link/index.test.tsx b/examples/kitchen-sink/packages/ui/src/link/index.test.tsx deleted file mode 100644 index d1a954e8a79fd..0000000000000 --- a/examples/kitchen-sink/packages/ui/src/link/index.test.tsx +++ /dev/null @@ -1,11 +0,0 @@ -import { createRoot } from "react-dom/client"; -import { Link } from "."; - -describe("Link", () => { - it("renders without crashing", () => { - const div = document.createElement("div"); - const root = createRoot(div); - root.render(Turborepo Docs); - root.unmount(); - }); -}); diff --git a/examples/kitchen-sink/packages/ui/src/link/index.tsx b/examples/kitchen-sink/packages/ui/src/link/index.tsx deleted file mode 100644 index b3e07394b16b8..0000000000000 --- a/examples/kitchen-sink/packages/ui/src/link/index.tsx +++ /dev/null @@ -1,25 +0,0 @@ -import type { AnchorHTMLAttributes, ReactNode } from "react"; - -interface LinkProps extends AnchorHTMLAttributes { - children: ReactNode; - newTab?: boolean; - href: string; -} - -export function Link({ - children, - href, - newTab, - ...other -}: LinkProps): JSX.Element { - return ( - - {children} - - ); -} From 6ee0d3bcc103f74cc6595254109b870e36a3ff59 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 30 Jul 2024 09:12:35 -0600 Subject: [PATCH 2/3] Add back files. --- .../packages/ui/src/link/index.test.tsx | 11 ++++++++ .../packages/ui/src/link/index.tsx | 25 +++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 examples/kitchen-sink/packages/ui/src/link/index.test.tsx create mode 100644 examples/kitchen-sink/packages/ui/src/link/index.tsx diff --git a/examples/kitchen-sink/packages/ui/src/link/index.test.tsx b/examples/kitchen-sink/packages/ui/src/link/index.test.tsx new file mode 100644 index 0000000000000..d1a954e8a79fd --- /dev/null +++ b/examples/kitchen-sink/packages/ui/src/link/index.test.tsx @@ -0,0 +1,11 @@ +import { createRoot } from "react-dom/client"; +import { Link } from "."; + +describe("Link", () => { + it("renders without crashing", () => { + const div = document.createElement("div"); + const root = createRoot(div); + root.render(Turborepo Docs); + root.unmount(); + }); +}); diff --git a/examples/kitchen-sink/packages/ui/src/link/index.tsx b/examples/kitchen-sink/packages/ui/src/link/index.tsx new file mode 100644 index 0000000000000..b3e07394b16b8 --- /dev/null +++ b/examples/kitchen-sink/packages/ui/src/link/index.tsx @@ -0,0 +1,25 @@ +import type { AnchorHTMLAttributes, ReactNode } from "react"; + +interface LinkProps extends AnchorHTMLAttributes { + children: ReactNode; + newTab?: boolean; + href: string; +} + +export function Link({ + children, + href, + newTab, + ...other +}: LinkProps): JSX.Element { + return ( + + {children} + + ); +} From 193f1ea621f403d69df3fd6159082c42f25a4572 Mon Sep 17 00:00:00 2001 From: Anthony Shew Date: Tue, 30 Jul 2024 09:14:06 -0600 Subject: [PATCH 3/3] Update crates/turborepo-lib/src/commands/prune.rs --- crates/turborepo-lib/src/commands/prune.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/turborepo-lib/src/commands/prune.rs b/crates/turborepo-lib/src/commands/prune.rs index d6715d7723a92..8c20d460f529f 100644 --- a/crates/turborepo-lib/src/commands/prune.rs +++ b/crates/turborepo-lib/src/commands/prune.rs @@ -24,7 +24,7 @@ pub const DEFAULT_OUTPUT_DIR: &str = "out"; pub enum Error { #[error("io error while pruning: {0}")] Io(#[from] std::io::Error), - #[error("File system error while pruning. The error from the operating system was: {0}")] + #[error("File system error while pruning. The error from the operating system is: {0}")] Fs(#[from] turborepo_fs::Error), #[error("json error while pruning: {0}")] Json(#[from] serde_json::Error),