fix: remove suffix

[juanpicado]

add new test scenarios

[anikethsaha]

🥇

[DanielRuf]

Might be better to update the lockfile in a separate commit. This would make the diffs much smaller and better to review locally =)

[anikethsaha]

yeah true, but when we make changes related to dep like version changing or dep remove/add, isn't it required to use the committed lock file in order to build the same env?

Having it in separate commit is useful cause it makes things kind opt-in or optional

[DanielRuf]

yeah true, but when we make changes related to dep like version changing or dep remove/add, isn't it required to use the committed lock file in order to build the same env?

Make two commits and push after these two.

[DanielRuf]

Only the pushes trigger CI, also see how we did it at https://github.com/bitExpert/mattermost-client-node/commits/develop

This also produces smaller commit objects / blobs in most cases and better compression in Git itself.

[anikethsaha]

Make two commits and push after these two.

lock file commit should be the last one?

[DanielRuf]

lock file commit should be the last one?

Exactly.

[anikethsaha]

lock file commit should be the last one?

Exactly.

yea...make sense 👍