Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceptionHandler cannot be registered to StreamObserverReadStream in manyToMany #141

Closed
0x01F4 opened this issue Nov 9, 2023 · 5 comments
Assignees
Labels
Milestone

Comments

@0x01F4
Copy link
Contributor

0x01F4 commented Nov 9, 2023

Version

4.4.6

Context

when io.vertx.grpc.stub.ClientCalls.manyToMany called if exception happens before returning the StreamObserverReadStream exception is lost.There is no way to register exceptionHandler before the call.We can register exceptionHandler only after StreamObserverReadStream return from manyToMany.

  public static <I, O> ReadStream<O> manyToMany(ContextInternal ctx, Handler<WriteStream<I>> requestHandler, Function<StreamObserver<O>, StreamObserver<I>> delegate) {
    StreamObserverReadStream<O> response = new StreamObserverReadStream<>();
    StreamObserver<I> request = delegate.apply(response);
    requestHandler.handle(new GrpcWriteStream<>(request));
    return response;
  }

Exception happens in StreamObserver<I> request = delegate.apply(response) and onError is called and exceptionHandler is null.

etcd-io/jetcd#1261 (comment)

@0x01F4 0x01F4 added the bug label Nov 9, 2023
@tsegismont tsegismont self-assigned this Nov 22, 2023
@tsegismont tsegismont added this to the 4.5.1 milestone Nov 22, 2023
@tsegismont
Copy link
Contributor

Fixed by e1848f2

@0x01F4
Copy link
Contributor Author

0x01F4 commented Nov 23, 2023

Fixed by e1848f2

when can I expect 4.5.1 to be released?

@0x01F4
Copy link
Contributor Author

0x01F4 commented Nov 27, 2023

Fixed by e1848f2

when can I expect 4.5.1 to be released?

@tsegismont will it be released soon?

@0x01F4
Copy link
Contributor Author

0x01F4 commented Nov 28, 2023

@vietj can I get some idea of when 4.5.1 will be released?

@vietj
Copy link
Contributor

vietj commented Dec 1, 2023

I think we will release in the first half of december

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants