Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document which packages are obsoleted by tokamak #26

Open
flying-sheep opened this issue Apr 13, 2016 · 10 comments
Open

document which packages are obsoleted by tokamak #26

flying-sheep opened this issue Apr 13, 2016 · 10 comments

Comments

@flying-sheep
Copy link
Contributor

so i found out i can disable

  • language-rust
  • terminal-plus
  • build-cargo

but not

  • linter-rust

by trial and error. it would be nice to have this on the webpage or readme

@vertexclique
Copy link
Owner

Can you please clarify this with what did you see as error?
Currently I had disabled linter-rust for example and it doesn't do linting?

Probably you don't want to see the statusbar at the bottom after disabling linter-rust right?
If it is like that linter is a atom plugin that serves as a plugin base for linting multiple languages with itself. First you can disable linter-rust then linter maybe? This way can be your solution.

@colin-kiegel
Copy link

I think the question:

Which other rust packages are redundant with tokamak and which can be used complementary?

At least that is what I was wondering too. So a short Statement like "you might want to combine this package with X, but you won't need Y" would help because other people might be wondering which packages they need.

@flying-sheep flying-sheep changed the title document which packages are opsoleted by tokamak document which packages are obsoleted by tokamak Apr 16, 2016
@flying-sheep
Copy link
Contributor Author

Which other rust packages are redundant with tokamak and which can be used complementary?

exactly. tokamak includes a rust grammar, so also installing language-rust is redundant and you end up with two selectable rust grammars.

so i would like tokamak to list packages that you can disable without losing functionality after installing tokamak

@vertexclique
Copy link
Owner

vertexclique commented May 2, 2016

OK the thing is linter-rust shows language-rust as dependency.
Yeah and we don't need grammar this is completely true, but we have contributed to original grammar by adding some fields which is not in language-rust.
https://github.com/AtomLinter/linter-rust/blob/master/package.json

So there are two options for that:

  • Use our own grammar - fork linter-rust and modify it for not using language-rust as package-dep
  • Use default grammar supplied by language-rust and remove default grammar in grammars. (In that case we couldn't update grammars by ourselves)

Your choice, your style.

@vertexclique
Copy link
Owner

@colin-kiegel
I couldn't understand what you mean by

you might want to combine this package with X, but you won't need Y

and redundant and complementary part. Redundant part is probably grammar part and complementary part is rest of it. Because if I exclude linter there will be no linter as you can think of.

@flying-sheep
Copy link
Contributor Author

in the first comment: language-rust, terminal-plus, build-cargo are redundant; linter-rust is complementary

@colin-kiegel
Copy link

Isn't it possible to contribute the grammar changes to language-rust upstream?

If that works out, tokamak could define language-rust as a dependency. Adding linter-rust wouldn't do any harm then.

@flying-sheep
Copy link
Contributor Author

huh? how does it do harm now?

@colin-kiegel
Copy link

sorry for the bad choice of words: Adding linter-rust wouldn't install any redundant dependencies then.

Better? :-)

@vertexclique
Copy link
Owner

Long time no see! Sorry for that. I will update repo wiki with this information too. Thanks for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants