Set minimum TLS version of webhook to 1.3 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring the webhook, this will set the minimum TLS version to 1.3. This is a bit of a hacky way to do this, but it will suffice until the controller-runtime allows this setting to be configure through the Manager.
roypaulin
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the webhook, this will set the minimum TLS version to 1.3. This is a bit of a hacky way to do this, but it will suffice until the controller-runtime allows this setting to be configure through the Manager. See #155 for more of a discussion on what changes we are waiting for in controller-runtime.
Fixes #155