Add the ability to override names in the helm chart. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 17, 2022 08:49
A new helm chart parameter was added (nameOverride) that allows you to control the prefix of all of the k8s objects created by the helm chart. If this is omitted, all of the objects have the name of the chart (verticadb-operator).
roypaulin
reviewed
Jul 18, 2022
| @@ -21,6 +21,9 @@ | |||
| # with the default values. | |||
| # ------------------------------------------------------------------------------- | |||
|
|
|||
| # To control the name of all of the objects created in the helm chart. | |||
| # nameOverride: verticadb-operator | |||
There was a problem hiding this comment.
Does it mean we are not using it yet?
There was a problem hiding this comment.
The override is an optional parm. If you don't set it, then the k8s objects will use the chart name of verticadb-operator. I just a put a comment here as a indication that this parm exists if you want to control the object names.
cmd/operator/main.go
Outdated
| @@ -118,6 +119,7 @@ func (fc *FlagConfig) setFlagArgs() { | |||
| "with the path /debug/pprof. See https://golang.org/pkg/net/http/pprof/ for more info.") | |||
| flag.StringVar(&fc.ServiceAccountName, "service-account-name", "verticadb-operator-controller-manager", | |||
| "The name of the serviceAccount to use.") | |||
| flag.StringVar(&fc.PrefixName, "prefix-name", "", "The common prefix for all objects created during the operator deployment") | |||
There was a problem hiding this comment.
I know it does not change anything but why not set the default value to "verticadb-operator" as done with ServiceAccountName?
There was a problem hiding this comment.
Sure, I will set this.
roypaulin
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new helm chart parameter was added that allows you to control the prefix of all of the k8s objects created by the helm chart. If this is omitted, all of the objects have the name of the chart (verticadb-operator).
For example, to force all objects created by the operator deployment to start with "special" you can use the nameOverride parameter.