-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an init program to vertica-k8s image #320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good ! Just have a comment.
paths.ConfigLogrotatePath, | ||
paths.ConfigSharePath, | ||
paths.HTTPTLSConfDir, paths.HTTPTLSConfFile, | ||
paths.ConfigLogrotatePath, paths.ConfigLogrotatePath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is each argument passed twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test each file like this:
echo -n ' %s: '
test -f %s && echo true || echo false
We want the file name to be displayed, then the actual test for the file after it. So, we need to reference the same variable twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah Ok, did not see it was fmt.Sprintf
This adds a proper init program to the vertica-k8s container so that it can reap zombie process and automatically restart cron/sshd if they fail. We use s6-overlay as our init program. It adds about 7MB (uncompressed) to our images.
There were a few additional items included in this due to that change: